checkpatch.pl: Use of uninitialized value $str in split at ./scripts/checkpatch.pl line 1079.

checkpatch.pl: Use of uninitialized value $str in split at ./scripts/checkpatch.pl line 1079.

[Charlemagne Lasse]

Hi,

I've noticed that checkpatch prints an error in linux-next. This can
be reproduced via

./scripts/checkpatch.pl --strict --file net/batman-adv/bat_iv_ogm.c

This problem seems to be introduced by d369873d2f53 ("Merge branch
'akpm-current/current'") which is a merge of 6a6594aace5c ("Merge
remote-tracking branch 'nvdimm/libnvdimm-for-next'") and cdaa6aa1e90c
("kexec_file fixup"). But please check this because I am new to
git-bisect

Greetings

Re: checkpatch.pl: Use of uninitialized value $str in split at ./scripts/checkpatch.pl line 1079.

[Joe Perches]

On Thu, 2016-09-08 at 08:23 +0200, Charlemagne Lasse wrote:
> I've noticed that checkpatch prints an error in linux-next. This can
> be reproduced via
> ./scripts/checkpatch.pl --strict --file net/batman-adv/bat_iv_ogm.c
> This problem seems to be introduced by d369873d2f53 ("Merge branch
> 'akpm-current/current'") which is a merge of 6a6594aace5c ("Merge
> remote-tracking branch 'nvdimm/libnvdimm-for-next'") and cdaa6aa1e90c
> ("kexec_file fixup"). But please check this because I am new to
> git-bisect

Thanks, I'll fix it.

[PATCH] checkpatch: Improve the block comment * alignment test

[Joe Perches]

An "uninitialized value" is emitted when a block comment starts on
the same line as a statement.

Fix this and make the test use a little fewer cpu cycles too.

Signed-off-by: Joe Perches <joe@perches.com>
Reported-by: Charlemagne Lasse <charlemagnelasse@gmail.com>
---
 scripts/checkpatch.pl | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 4ecb66c..d7cee13 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3005,18 +3005,23 @@ sub process {
 
 # Block comment * alignment
 		if ($prevline =~ /$;[ \t]*$/ &&			#ends in comment
-		    (($prevrawline =~ /^\+.*?\/\*/ &&		#starting /*
+		    $line =~ /^\+[ \t]*$;/ &&			#leading comment
+		    $rawline =~ /^\+[ \t]*\*/ &&		#leading *
+		    (($prevrawline =~ /^\+.*?\/\*/ &&		#leading /*
 		      $prevrawline !~ /\*\/[ \t]*$/) ||		#no trailing */
-		     $prevrawline =~ /^\+[ \t]*\*/) &&		#starting *
-		    $rawline =~ /^\+[ \t]*\*/) {		#rawline *
+		     $prevrawline =~ /^\+[ \t]*\*/)) {		#leading *
+			my $oldindent;
 			$prevrawline =~ m@^\+([ \t]*/?)\*@;
-			my $oldindent = expand_tabs($1);
+			if (defined($1)) {
+				$oldindent = expand_tabs($1);
+			} else {
+				$prevrawline =~ m@^\+(.*/?)\*@;
+				$oldindent = expand_tabs($1);
+			}
 			$rawline =~ m@^\+([ \t]*)\*@;
 			my $newindent = $1;
-			my $test_comment = '^\\+' . "$;" x (length($newindent) + 1);
 			$newindent = expand_tabs($newindent);
-			if ($line =~ /$test_comment/ &&
-			    length($oldindent) ne length($newindent)) {
+			if (length($oldindent) ne length($newindent)) {
 				WARN("BLOCK_COMMENT_STYLE",
 				     "Block comments should align the * on each line\n" . $hereprev);
 			}
-- 
2.10.0.rc2.1.g053435c