From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, david@gibson.dropbear.id.au
Cc: alex.bennee@linaro.org, qemu-devel@nongnu.org, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v3 3/3] target-ppc: tlbie should have global effect
Date: Mon, 12 Sep 2016 16:08:50 +1000 [thread overview]
Message-ID: <1473660530.8689.240.camel@kernel.crashing.org> (raw)
In-Reply-To: <1473659314-11813-4-git-send-email-nikunj@linux.vnet.ibm.com>
On Mon, 2016-09-12 at 11:18 +0530, Nikunj A Dadhania wrote:
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 5026804..d96ff66 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -4448,6 +4448,7 @@ static void gen_tlbie(DisasContext *ctx)
> #if defined(CONFIG_USER_ONLY)
> GEN_PRIV;
> #else
> + TCGv_i32 t1;
> CHK_HV;
>
> if (NARROW_MODE(ctx)) {
> @@ -4458,6 +4459,11 @@ static void gen_tlbie(DisasContext *ctx)
> } else {
> gen_helper_tlbie(cpu_env, cpu_gpr[rB(ctx->opcode)]);
> }
> + t1 = tcg_temp_new_i32();
> + tcg_gen_ld_i32(t1, cpu_env, offsetof(CPUPPCState, tlb_need_flush));
> + tcg_gen_ori_i32(t1, t1, TLB_NEED_GLOBAL_FLUSH);
> + tcg_gen_st_i32(t1, cpu_env, offsetof(CPUPPCState, tlb_need_flush));
> + tcg_temp_free_i32(t1);
> #endif /* defined(CONFIG_USER_ONLY) */
Why not do this in the helper ?
Cheers,
Ben.
next prev parent reply other threads:[~2016-09-12 6:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 5:48 [Qemu-devel] [PATCH v3 0/3] ppc: Broadcast tlb flush should have global effect Nikunj A Dadhania
2016-09-12 5:48 ` [Qemu-devel] [PATCH v3 1/3] target-ppc: add TLB_NEED_LOCAL_FLUSH flag Nikunj A Dadhania
2016-09-12 5:48 ` [Qemu-devel] [PATCH v3 2/3] target-ppc: add flag in chech_tlb_flush() Nikunj A Dadhania
2016-09-14 3:09 ` David Gibson
2016-09-14 3:49 ` Benjamin Herrenschmidt
2016-09-14 3:53 ` Nikunj A Dadhania
2016-09-14 4:37 ` Benjamin Herrenschmidt
2016-09-14 5:09 ` Nikunj A Dadhania
2016-09-14 5:18 ` David Gibson
2016-09-12 5:48 ` [Qemu-devel] [PATCH v3 3/3] target-ppc: tlbie should have global effect Nikunj A Dadhania
2016-09-12 6:08 ` Benjamin Herrenschmidt [this message]
2016-09-12 6:15 ` Nikunj A Dadhania
2016-09-12 6:21 ` Nikunj A Dadhania
2016-09-12 6:05 ` [Qemu-devel] [PATCH v3 0/3] ppc: Broadcast tlb flush " Benjamin Herrenschmidt
2016-09-12 6:16 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473660530.8689.240.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=alex.bennee@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.