All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org, qemu-devel@nongnu.org
Cc: mreitz@redhat.com, kwolf@redhat.com, jcody@redhat.com,
	jsnow@redhat.com, famz@redhat.com, den@openvz.org,
	stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] backup: allow target without .bdrv_get_info
Date: Wed, 15 Feb 2017 15:41:22 +0300	[thread overview]
Message-ID: <14737a38-e25f-3df1-16b6-4bbaedfeea40@virtuozzo.com> (raw)
In-Reply-To: <1487156985-18321-1-git-send-email-vsementsov@virtuozzo.com>

15.02.2017 14:09, Vladimir Sementsov-Ogievskiy wrote:
> Currently backup to nbd target is broken, as nbd doesn't have
> .bdrv_get_info realization.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>
> v2: add WARNING
>
> ===
>
> Since commit
>
> commit 4c9bca7e39a6e07ad02c1dcde3478363344ec60b
> Author: John Snow <jsnow@redhat.com>
> Date:   Thu Feb 25 15:58:30 2016 -0500
>
>      block/backup: avoid copying less than full target clusters
>
> backup to nbd target is broken, we have "Couldn't determine the cluster size of
> the target image".
>
> Proposed NBD protocol extension - NBD_OPT_INFO should finally solve this problem.
> But until it is not realized, we need allow backup to nbd target due to backward
> compatibility.
>
> Furthermore, is it entirely ok to disallow backup if bds lacks .bdrv_get_info?
> Which behavior should be default: to fail backup or to use default cluster size?
>
>   block/backup.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/block/backup.c b/block/backup.c
> index ea38733..a464b63 100644
> --- a/block/backup.c
> +++ b/block/backup.c
> @@ -638,7 +638,15 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
>        * backup cluster size is smaller than the target cluster size. Even for
>        * targets with a backing file, try to avoid COW if possible. */
>       ret = bdrv_get_info(target, &bdi);
> -    if (ret < 0 && !target->backing) {
> +    if (ret == -ENOTSUP) {
> +        /* Cluster size is not defined */
> +        error_report("WARNING: Target block device doesn't provide information "

ahah, even for such a small patches compilation should be checked.
implicit declaration of function ‘error_report'

will switch to fprintf(stderr,

> +                     "about block size and it doesn't have backing file. "
> +                     "Default block size of %u bytes is used. If actual block "
> +                     "size of target exceeds this default, destination image "
> +                     "may become unusable");
> +        job->cluster_size = BACKUP_CLUSTER_SIZE_DEFAULT;
> +    } else if (ret < 0 && !target->backing) {
>           error_setg_errno(errp, -ret,
>               "Couldn't determine the cluster size of the target image, "
>               "which has no backing file");


-- 
Best regards,
Vladimir

      parent reply	other threads:[~2017-02-15 12:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-15 11:09 [Qemu-devel] [PATCH v2] backup: allow target without .bdrv_get_info Vladimir Sementsov-Ogievskiy
2017-02-15 11:33 ` Fam Zheng
2017-02-15 11:42   ` Vladimir Sementsov-Ogievskiy
2017-02-15 12:00     ` Fam Zheng
2017-02-15 12:37 ` no-reply
2017-02-15 12:41 ` Vladimir Sementsov-Ogievskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14737a38-e25f-3df1-16b6-4bbaedfeea40@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.