From: Fam Zheng <famz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com,
kwolf@redhat.com, jcody@redhat.com, jsnow@redhat.com,
den@openvz.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] backup: allow target without .bdrv_get_info
Date: Wed, 15 Feb 2017 20:00:15 +0800 [thread overview]
Message-ID: <20170215120015.GC1134@lemon.lan> (raw)
In-Reply-To: <b12de021-3baa-4e35-1a84-eafb5d1650cf@virtuozzo.com>
On Wed, 02/15 14:42, Vladimir Sementsov-Ogievskiy wrote:
> 15.02.2017 14:33, Fam Zheng wrote:
> > On Wed, 02/15 14:09, Vladimir Sementsov-Ogievskiy wrote:
> > > Currently backup to nbd target is broken, as nbd doesn't have
> > > .bdrv_get_info realization.
> > >
> > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > > ---
> > >
> > > v2: add WARNING
> > >
> > > ===
> > >
> > > Since commit
> > >
> > > commit 4c9bca7e39a6e07ad02c1dcde3478363344ec60b
> > > Author: John Snow <jsnow@redhat.com>
> > > Date: Thu Feb 25 15:58:30 2016 -0500
> > >
> > > block/backup: avoid copying less than full target clusters
> > >
> > > backup to nbd target is broken, we have "Couldn't determine the cluster size of
> > > the target image".
> > >
> > > Proposed NBD protocol extension - NBD_OPT_INFO should finally solve this problem.
> > > But until it is not realized, we need allow backup to nbd target due to backward
> > > compatibility.
> > If you respin, including above in the commit message is even better, IMO.
> >
> > > Furthermore, is it entirely ok to disallow backup if bds lacks .bdrv_get_info?
> > > Which behavior should be default: to fail backup or to use default cluster size?
> > >
> > > block/backup.c | 10 +++++++++-
> > > 1 file changed, 9 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/block/backup.c b/block/backup.c
> > > index ea38733..a464b63 100644
> > > --- a/block/backup.c
> > > +++ b/block/backup.c
> > > @@ -638,7 +638,15 @@ BlockJob *backup_job_create(const char *job_id, BlockDriverState *bs,
> > > * backup cluster size is smaller than the target cluster size. Even for
> > > * targets with a backing file, try to avoid COW if possible. */
> > > ret = bdrv_get_info(target, &bdi);
> > > - if (ret < 0 && !target->backing) {
> > > + if (ret == -ENOTSUP) {
> > > + /* Cluster size is not defined */
> > > + error_report("WARNING: Target block device doesn't provide information "
> > > + "about block size and it doesn't have backing file. "
> > > + "Default block size of %u bytes is used. If actual block "
> > > + "size of target exceeds this default, destination image "
> > > + "may become unusable");
> > "Image unusable" might be too strong here because it sounds like a serious
> > damage to the image, while actually what we mean is "backup unusable".
>
> Finally, "... default, backup may be unusable"?
Yes, looks good.
Fam
next prev parent reply other threads:[~2017-02-15 12:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-15 11:09 [Qemu-devel] [PATCH v2] backup: allow target without .bdrv_get_info Vladimir Sementsov-Ogievskiy
2017-02-15 11:33 ` Fam Zheng
2017-02-15 11:42 ` Vladimir Sementsov-Ogievskiy
2017-02-15 12:00 ` Fam Zheng [this message]
2017-02-15 12:37 ` no-reply
2017-02-15 12:41 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215120015.GC1134@lemon.lan \
--to=famz@redhat.com \
--cc=den@openvz.org \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.