From: "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
To: "Nikula, Jani" <jani.nikula@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 4/6] drm/i915: use NULL for NULL pointers
Date: Thu, 15 Sep 2016 17:09:13 +0000 [thread overview]
Message-ID: <1473960273.32398.1.camel@dk-H97M-D3H> (raw)
In-Reply-To: <1473946137-1931-4-git-send-email-jani.nikula@intel.com>
Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
On Thu, 2016-09-15 at 16:28 +0300, Jani Nikula wrote:
> Fix sparse warning:
>
> drivers/gpu/drm/i915/i915_cmd_parser.c:987:72: warning: Using plain
> integer as NULL pointer
>
> Fixes: 52a42cec4b70 ("drm/i915/cmdparser: Accelerate copies from WC memory")
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_cmd_parser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_cmd_parser.c b/drivers/gpu/drm/i915/i915_cmd_parser.c
> index 3c72b3b103e7..70980f82a15b 100644
> --- a/drivers/gpu/drm/i915/i915_cmd_parser.c
> +++ b/drivers/gpu/drm/i915/i915_cmd_parser.c
> @@ -984,7 +984,7 @@ static u32 *copy_batch(struct drm_i915_gem_object *dst_obj,
>
> src = ERR_PTR(-ENODEV);
> if (src_needs_clflush &&
> - i915_memcpy_from_wc((void *)(uintptr_t)batch_start_offset, 0, 0)) {
> + i915_memcpy_from_wc((void *)(uintptr_t)batch_start_offset, NULL, 0)) {
> src = i915_gem_object_pin_map(src_obj, I915_MAP_WC);
> if (!IS_ERR(src)) {
> i915_memcpy_from_wc(dst,
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-15 17:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 13:28 [PATCH 1/6] drm/i915: make intel_dp_compute_bpp static Jani Nikula
2016-09-15 13:28 ` [PATCH 2/6] drm/i915: do not use 'false' as a NULL pointer Jani Nikula
2016-09-15 17:13 ` Pandiyan, Dhinakaran
2016-09-15 13:28 ` [PATCH 3/6] drm/i915: keep declarations in i915_drv.h Jani Nikula
2016-09-19 16:14 ` Joonas Lahtinen
2016-09-20 8:57 ` Jani Nikula
2016-09-20 9:29 ` Chris Wilson
2016-09-20 9:58 ` Jani Nikula
2016-09-22 11:50 ` Daniel Vetter
2016-09-22 12:11 ` Jani Nikula
2016-09-26 6:32 ` Joonas Lahtinen
2016-09-15 13:28 ` [PATCH 4/6] drm/i915: use NULL for NULL pointers Jani Nikula
2016-09-15 17:09 ` Pandiyan, Dhinakaran [this message]
2016-09-15 13:28 ` [PATCH 5/6] drm/i915: workaround sparse warning on variable length arrays Jani Nikula
2016-09-15 13:28 ` [PATCH 6/6] drm/i915: silence io mapping/unmapping sparse warnings on different address spaces Jani Nikula
2016-09-15 13:49 ` ✗ Fi.CI.BAT: warning for series starting with [1/6] drm/i915: make intel_dp_compute_bpp static Patchwork
2016-09-15 14:35 ` [PATCH 1/6] " Jim Bride
2016-09-16 7:45 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473960273.32398.1.camel@dk-H97M-D3H \
--to=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.