All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/6] drm/i915: keep declarations in i915_drv.h
Date: Thu, 22 Sep 2016 15:11:35 +0300	[thread overview]
Message-ID: <8737ksp214.fsf@intel.com> (raw)
In-Reply-To: <20160922115039.GG22164@dvetter-linux.ger.corp.intel.com>

On Thu, 22 Sep 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Tue, Sep 20, 2016 at 12:58:20PM +0300, Jani Nikula wrote:
>> On Tue, 20 Sep 2016, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> > On Tue, Sep 20, 2016 at 11:57:06AM +0300, Jani Nikula wrote:
>> >> On Mon, 19 Sep 2016, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
>> >> > On to, 2016-09-15 at 16:28 +0300, Jani Nikula wrote:
>> >> >> Fix sparse warnings:
>> >> >> 
>> >> >> drivers/gpu/drm/i915/i915_drv.c:1179:5: warning: symbol
>> >> >> 'i915_driver_load' was not declared. Should it be static?
>> >> >> 
>> >> >> drivers/gpu/drm/i915/i915_drv.c:1267:6: warning: symbol
>> >> >> 'i915_driver_unload' was not declared. Should it be static?
>> >> >> 
>> >> >> drivers/gpu/drm/i915/i915_drv.c:2444:25: warning: symbol 'i915_pm_ops'
>> >> >> was not declared. Should it be static?
>> >> >> 
>> >> >
>> >> > Hmm, Chris, were not these change in the middle of a series, did the
>> >> > cleanup patches just fall off?
>> >> 
>> >> Can we just please use whichever patches that fix the issue?
>> >
>> > It was deliberate placement to avoid having those symbols exposed to
>> > every user of i915_drv.h, i.e. everyone. Limit i915_drv.h to the
>> > interface exposed by i915_drv.c and so used only by a handful of files.
>> 
>> I can see that, but I prefer to get the warnings gone.
>
> Yeah, non-static declarations need to be in header files, otherwise
> there's not much point in them really (since the compiler can't compare
> the delcaration with the definition).
>
> we also need to split up our headers I think, and I plan to start doing
> that when extracting bits and pieces from intel_display.c. In drm core at
> least having 1:1 between headers and source files seems to work rather
> well.
>
> Meanwhile on Jani's patch:
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Thanks, pushed to dinq.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2016-09-22 13:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-15 13:28 [PATCH 1/6] drm/i915: make intel_dp_compute_bpp static Jani Nikula
2016-09-15 13:28 ` [PATCH 2/6] drm/i915: do not use 'false' as a NULL pointer Jani Nikula
2016-09-15 17:13   ` Pandiyan, Dhinakaran
2016-09-15 13:28 ` [PATCH 3/6] drm/i915: keep declarations in i915_drv.h Jani Nikula
2016-09-19 16:14   ` Joonas Lahtinen
2016-09-20  8:57     ` Jani Nikula
2016-09-20  9:29       ` Chris Wilson
2016-09-20  9:58         ` Jani Nikula
2016-09-22 11:50           ` Daniel Vetter
2016-09-22 12:11             ` Jani Nikula [this message]
2016-09-26  6:32             ` Joonas Lahtinen
2016-09-15 13:28 ` [PATCH 4/6] drm/i915: use NULL for NULL pointers Jani Nikula
2016-09-15 17:09   ` Pandiyan, Dhinakaran
2016-09-15 13:28 ` [PATCH 5/6] drm/i915: workaround sparse warning on variable length arrays Jani Nikula
2016-09-15 13:28 ` [PATCH 6/6] drm/i915: silence io mapping/unmapping sparse warnings on different address spaces Jani Nikula
2016-09-15 13:49 ` ✗ Fi.CI.BAT: warning for series starting with [1/6] drm/i915: make intel_dp_compute_bpp static Patchwork
2016-09-15 14:35 ` [PATCH 1/6] " Jim Bride
2016-09-16  7:45   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8737ksp214.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.