From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH v4 1/3] nvme/scsi: Remove power management support
Date: Fri, 16 Sep 2016 16:37:44 -0700 [thread overview]
Message-ID: <1474069064.10494.4.camel@linux.intel.com> (raw)
In-Reply-To: <714df91022b06c6799afb315962769f22b8ab9f4.1474049701.git.luto@kernel.org>
On Fri, 2016-09-16@11:16 -0700, Andy Lutomirski wrote:
> As far as I can tell, there is basically nothing correct about this
> code.??It misinterprets npss (off-by-one).??It hardcodes a bunch of
> power states, which is nonsense, because they're all just indices
> into a table that software needs to parse.??It completely ignores
> the distinction between operational and non-operational states.
> And, until 4.8, if all of the above magically succeeded, it would
> dereference a NULL pointer and OOPS.
>
> Since this code appears to be useless, just delete it.
Acked-by: Jay Freyensee <james_p_freyensee at linux.intel.com>
>
> Signed-off-by: Andy Lutomirski <luto at kernel.org>
> ---
>?
WARNING: multiple messages have this Message-ID (diff)
From: J Freyensee <james_p_freyensee@linux.intel.com>
To: Andy Lutomirski <luto@kernel.org>,
Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/3] nvme/scsi: Remove power management support
Date: Fri, 16 Sep 2016 16:37:44 -0700 [thread overview]
Message-ID: <1474069064.10494.4.camel@linux.intel.com> (raw)
In-Reply-To: <714df91022b06c6799afb315962769f22b8ab9f4.1474049701.git.luto@kernel.org>
On Fri, 2016-09-16 at 11:16 -0700, Andy Lutomirski wrote:
> As far as I can tell, there is basically nothing correct about this
> code. It misinterprets npss (off-by-one). It hardcodes a bunch of
> power states, which is nonsense, because they're all just indices
> into a table that software needs to parse. It completely ignores
> the distinction between operational and non-operational states.
> And, until 4.8, if all of the above magically succeeded, it would
> dereference a NULL pointer and OOPS.
>
> Since this code appears to be useless, just delete it.
Acked-by: Jay Freyensee <james_p_freyensee@linux.intel.com>
>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
>
next prev parent reply other threads:[~2016-09-16 23:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 18:16 [PATCH v4 0/3] nvme power saving Andy Lutomirski
2016-09-16 18:16 ` Andy Lutomirski
2016-09-16 18:16 ` [PATCH v4 1/3] nvme/scsi: Remove power management support Andy Lutomirski
2016-09-16 18:16 ` Andy Lutomirski
2016-09-16 23:37 ` J Freyensee [this message]
2016-09-16 23:37 ` J Freyensee
2016-09-16 18:16 ` [PATCH v4 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features() Andy Lutomirski
2016-09-16 18:16 ` Andy Lutomirski
2016-09-16 18:16 ` [PATCH v4 3/3] nvme: Enable autonomous power state transitions Andy Lutomirski
2016-09-16 18:16 ` Andy Lutomirski
2016-09-17 0:49 ` [PATCH v4 0/3] nvme power saving J Freyensee
2016-09-17 0:49 ` J Freyensee
2016-09-22 0:11 ` Andy Lutomirski
2016-09-22 0:11 ` Andy Lutomirski
2016-09-22 13:21 ` Christoph Hellwig
2016-09-22 13:21 ` Christoph Hellwig
2016-09-22 14:23 ` Jens Axboe
2016-09-22 14:23 ` Jens Axboe
2016-09-22 20:11 ` Andy Lutomirski
2016-09-22 20:11 ` Andy Lutomirski
2016-09-22 20:43 ` Jens Axboe
2016-09-22 20:43 ` Jens Axboe
2016-09-22 21:33 ` J Freyensee
2016-09-22 21:33 ` J Freyensee
2016-09-22 22:15 ` Andy Lutomirski
2016-09-22 22:15 ` Andy Lutomirski
2016-10-28 0:06 ` Andy Lutomirski
2016-10-28 0:06 ` Andy Lutomirski
2016-10-28 5:29 ` Christoph Hellwig
2016-10-28 5:29 ` Christoph Hellwig
2016-09-22 22:16 ` Keith Busch
2016-09-22 22:16 ` Keith Busch
2016-09-22 22:07 ` Jens Axboe
2016-09-22 22:07 ` Jens Axboe
2016-09-23 23:42 ` Christoph Hellwig
2016-09-23 23:42 ` Christoph Hellwig
2016-09-24 16:55 ` Jens Axboe
2016-09-24 16:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474069064.10494.4.camel@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.