[v2] e2fsprogs: add packageconfig for -file-

[v2] e2fsprogs: add packageconfig for -file-

[Randy MacLeod]

Without a packageconfig dependency for the file utility, there's
a rare compile faiure caused by a race where the magic.h
header file is not found:

 ../../../git/lib/support/plausible.c:33:19: fatal error: magic.h: No such file or directory

This file, plausible.c, is part of libsupport.a which is used by
many binaries produced by the e2fsprogs package. plausible.c attempts
to dynamically load libmagic.so if the e2fsprogs configure detects
that magic was available. Adding the packageconfig will eliminate
the compile-time as well as the possible configure-time race condition.

Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
---
 meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb
index f4855bc..0d7a42b 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.43.bb
@@ -22,7 +22,8 @@ EXTRA_OECONF += "--libdir=${base_libdir} --sbindir=${base_sbindir} \
 
 EXTRA_OECONF_darwin = "--libdir=${base_libdir} --sbindir=${base_sbindir} --enable-bsd-shlibs"
 
-PACKAGECONFIG ??= ""
+PACKAGECONFIG ??= "file"
+PACKAGECONFIG[file] = ',,file'
 PACKAGECONFIG[fuse] = '--enable-fuse2fs,--disable-fuse2fs,fuse'
 
 do_configure_prepend () {
-- 
1.9.1

Re: [v2] e2fsprogs: add packageconfig for -file-

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

On 19 September 2016 at 21:22, Randy MacLeod <Randy.MacLeod@windriver.com>
wrote:

> +PACKAGECONFIG ??= "file"
> +PACKAGECONFIG[file] = ',,file'
>

This still has the non-determinism problem if file is disabled in
PACKAGECONFIG.

If the configure.ac doesn't have options but is doing standard
AC_CHECK_HEADERS or similar then you can preseed the autoconf cache values,
grepping oe-core or ac_cv_ will find plenty of prior art.

Ross

[-- Attachment #2: Type: text/html, Size: 977 bytes --]