From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
bharata@linux.vnet.ibm.com, aik@ozlabs.ru
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
david@gibson.dropbear.id.au, clg@kaod.org
Subject: Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken
Date: Thu, 22 Sep 2016 20:04:31 +1000 [thread overview]
Message-ID: <1474538671.2857.169.camel@kernel.crashing.org> (raw)
In-Reply-To: <87d1jw5mr0.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me>
On Thu, 2016-09-22 at 14:34 +0530, Nikunj A Dadhania wrote:
> Something like this works for KVM:
>
> diff --git a/target-ppc/machine.c b/target-ppc/machine.c
> index 4820f22..1cf3779 100644
> --- a/target-ppc/machine.c
> +++ b/target-ppc/machine.c
> @@ -563,8 +563,8 @@ const VMStateDescription vmstate_ppc_cpu = {
>
> /* Sanity checking */
> VMSTATE_UINTTL_EQUAL(env.msr_mask, PowerPCCPU),
> - VMSTATE_UINT64_EQUAL(env.insns_flags, PowerPCCPU),
> - VMSTATE_UINT64_EQUAL(env.insns_flags2, PowerPCCPU),
> + VMSTATE_UNUSED(sizeof(target_ulong)), /* was _EQUAL(env.insns_flags) */
> + VMSTATE_UNUSED(sizeof(target_ulong)), /* was _EQUAL(env.insns_flags2) */
> VMSTATE_UINT32_EQUAL(env.nb_BATs, PowerPCCPU),
> VMSTATE_END_OF_LIST()
> },
>
> TCG migration still remains broken with this.
Can we have conditionally present flags and a post-load that does some
matching ?
Cheers,
Ben.
next prev parent reply other threads:[~2016-09-22 10:04 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 5:21 [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken Bharata B Rao
2016-09-22 5:30 ` David Gibson
2016-09-22 6:00 ` Bharata B Rao
2016-09-22 6:36 ` Cédric Le Goater
2016-09-22 9:46 ` Dr. David Alan Gilbert
2016-09-22 10:01 ` Nikunj A Dadhania
2016-09-22 10:28 ` Dr. David Alan Gilbert
2016-09-22 11:18 ` Nikunj A Dadhania
2016-09-22 6:07 ` Benjamin Herrenschmidt
2016-09-22 6:15 ` Bharata B Rao
2016-09-22 8:47 ` Benjamin Herrenschmidt
2016-09-22 9:04 ` Nikunj A Dadhania
2016-09-22 10:04 ` Benjamin Herrenschmidt [this message]
2016-09-22 10:32 ` Paolo Bonzini
2016-09-22 11:07 ` Benjamin Herrenschmidt
2016-09-23 1:01 ` David Gibson
2016-09-22 11:07 ` Nikunj A Dadhania
2016-09-22 11:27 ` Cédric Le Goater
2016-09-22 11:37 ` Benjamin Herrenschmidt
2016-09-23 1:37 ` David Gibson
2016-09-23 3:27 ` Benjamin Herrenschmidt
2016-09-23 5:49 ` David Gibson
2016-09-22 19:00 ` Nikunj A Dadhania
2016-09-22 16:07 ` Dr. David Alan Gilbert
2016-09-22 17:27 ` Nikunj A Dadhania
2016-09-22 10:34 ` Alexey Kardashevskiy
2016-09-22 11:09 ` Benjamin Herrenschmidt
2016-09-23 0:52 ` David Gibson
2016-09-23 3:18 ` Nikunj A Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474538671.2857.169.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=aik@ozlabs.ru \
--cc=bharata@linux.vnet.ibm.com \
--cc=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=nikunj@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.