All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
	Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>,
	bharata@linux.vnet.ibm.com, aik@ozlabs.ru
Cc: clg@kaod.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken
Date: Thu, 22 Sep 2016 21:07:56 +1000	[thread overview]
Message-ID: <1474542476.2857.172.camel@kernel.crashing.org> (raw)
In-Reply-To: <a9fdbcce-ce69-c51e-0c99-e95ac1e45bb2@redhat.com>

On Thu, 2016-09-22 at 12:32 +0200, Paolo Bonzini wrote:
> *However* a better fix would be to preserve the old flags for
> pseries-2.6, and only set the newer flags for pseries-2.7.  I'm not
> saying you have to do this, but if it's not hard (no idea) why not learn
> how to do it right.
> 
> The design is not stupid, it's just that compatibility is harder than
> you think and you are going through the same learning experiences that
> x86 went though.

Yeah well, the design is stupid inside target-ppc is what I meant in
the sense that it should have been clearer that those flags should not
have affected KVM, especially knowing that TCG still needed a lot of
work to add all the proper HV stuff.

Also most/all those flags concern instructions that are not relevant to
the "PAPR" mode which is running the guest with HV disabled, so
additionally, we might want to consider being smarter in the compare as
well to make sure that only the flags relevant to guest mode are
compared when the vCPU is in PAPR mode.

Cheers,
Ben.

  reply	other threads:[~2016-09-22 11:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22  5:21 [Qemu-devel] pseries-2.6 migration from QEMU-2.6 to QEMU-2.7 broken Bharata B Rao
2016-09-22  5:30 ` David Gibson
2016-09-22  6:00   ` Bharata B Rao
2016-09-22  6:36     ` Cédric Le Goater
2016-09-22  9:46     ` Dr. David Alan Gilbert
2016-09-22 10:01       ` Nikunj A Dadhania
2016-09-22 10:28         ` Dr. David Alan Gilbert
2016-09-22 11:18           ` Nikunj A Dadhania
2016-09-22  6:07 ` Benjamin Herrenschmidt
2016-09-22  6:15   ` Bharata B Rao
2016-09-22  8:47     ` Benjamin Herrenschmidt
2016-09-22  9:04       ` Nikunj A Dadhania
2016-09-22 10:04         ` Benjamin Herrenschmidt
2016-09-22 10:32           ` Paolo Bonzini
2016-09-22 11:07             ` Benjamin Herrenschmidt [this message]
2016-09-23  1:01             ` David Gibson
2016-09-22 11:07           ` Nikunj A Dadhania
2016-09-22 11:27             ` Cédric Le Goater
2016-09-22 11:37               ` Benjamin Herrenschmidt
2016-09-23  1:37                 ` David Gibson
2016-09-23  3:27                   ` Benjamin Herrenschmidt
2016-09-23  5:49                     ` David Gibson
2016-09-22 19:00               ` Nikunj A Dadhania
2016-09-22 16:07             ` Dr. David Alan Gilbert
2016-09-22 17:27               ` Nikunj A Dadhania
2016-09-22 10:34         ` Alexey Kardashevskiy
2016-09-22 11:09           ` Benjamin Herrenschmidt
2016-09-23  0:52         ` David Gibson
2016-09-23  3:18           ` Nikunj A Dadhania

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1474542476.2857.172.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=aik@ozlabs.ru \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=nikunj@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.