From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static
Date: Sun, 25 Sep 2016 15:23:37 -0700 [thread overview]
Message-ID: <1474842217.2751.6.camel@intel.com> (raw)
In-Reply-To: <1474783558-7384-1-git-send-email-baoyou.xie@linaro.org>
On Sun, 2016-09-25 at 14:05 +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous
> prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> ?drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
> ?1 file changed, 2 insertions(+), 2 deletions(-)
This has been fixed as well, and there is already a patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20160925/f49e25c3/attachment.asc>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Baoyou Xie <baoyou.xie@linaro.org>, intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, xie.baoyou@zte.com.cn
Subject: Re: [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static
Date: Sun, 25 Sep 2016 15:23:37 -0700 [thread overview]
Message-ID: <1474842217.2751.6.camel@intel.com> (raw)
In-Reply-To: <1474783558-7384-1-git-send-email-baoyou.xie@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
On Sun, 2016-09-25 at 14:05 +0800, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/net/ethernet/intel/igb/igb_ethtool.c:2707:5: warning: no previous
> prototype for 'igb_rxnfc_write_vlan_prio_filter' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This has been fixed as well, and there is already a patch.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-25 22:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 6:05 [Intel-wired-lan] [PATCH] igb: mark igb_rxnfc_write_vlan_prio_filter() static Baoyou Xie
2016-09-25 6:05 ` Baoyou Xie
2016-09-25 22:23 ` Jeff Kirsher [this message]
2016-09-25 22:23 ` Jeff Kirsher
2016-09-25 23:14 ` [Intel-wired-lan] " Arnd Bergmann
2016-09-25 23:14 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2016-09-18 8:50 [Intel-wired-lan] " Baoyou Xie
2016-09-19 22:16 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474842217.2751.6.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.