From: Joe Perches <joe@perches.com>
To: Eric Salem <ericsalem@gmail.com>, greg@kroah.com
Cc: arve@android.com, riandrews@android.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: android: fixed permissions style issue
Date: Sun, 25 Sep 2016 20:00:36 -0700 [thread overview]
Message-ID: <1474858836.2238.10.camel@perches.com> (raw)
In-Reply-To: <b3ce9fef-4602-5a5f-4633-4fcda635034f@gmail.com>
On Sun, 2016-09-25 at 21:47 -0500, Eric Salem wrote:
> Fixed a coding style issue. Changed symbolic permissions to octal.
If you do these, please shorten the lines where possible.
> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
[]
> @@ -204,10 +204,10 @@ device_initcall(lowmem_init);
> * not really modular, but the easiest way to keep compat with existing
> * bootargs behaviour is to continue using module_param here.
> */
> -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
> +module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
> module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size,
> - S_IRUGO | S_IWUSR);
> + 0644);
module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, 0644);
etc...
next prev parent reply other threads:[~2016-09-26 3:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 2:47 [PATCH] Staging: android: fixed permissions style issue Eric Salem
2016-09-26 3:00 ` Joe Perches [this message]
2016-09-26 3:33 ` [PATCH v2] " Eric Salem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474858836.2238.10.camel@perches.com \
--to=joe@perches.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=ericsalem@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.