* [PATCH] Staging: android: fixed permissions style issue @ 2016-09-26 2:47 Eric Salem 2016-09-26 3:00 ` Joe Perches 0 siblings, 1 reply; 3+ messages in thread From: Eric Salem @ 2016-09-26 2:47 UTC (permalink / raw) To: greg; +Cc: arve, riandrews, devel, linux-kernel Fixed a coding style issue. Changed symbolic permissions to octal. Signed-off-by: Eric Salem <ericsalem@gmail.com> --- drivers/staging/android/lowmemorykiller.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c index 80d7adf..553a3ee 100644 --- a/drivers/staging/android/lowmemorykiller.c +++ b/drivers/staging/android/lowmemorykiller.c @@ -204,10 +204,10 @@ device_initcall(lowmem_init); * not really modular, but the easiest way to keep compat with existing * bootargs behaviour is to continue using module_param here. */ -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); +module_param_named(cost, lowmem_shrinker.seeks, int, 0644); module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, - S_IRUGO | S_IWUSR); + 0644); module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size, - S_IRUGO | S_IWUSR); -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR); + 0644); +module_param_named(debug_level, lowmem_debug_level, uint, 0644); -- 2.7.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: android: fixed permissions style issue 2016-09-26 2:47 [PATCH] Staging: android: fixed permissions style issue Eric Salem @ 2016-09-26 3:00 ` Joe Perches 2016-09-26 3:33 ` [PATCH v2] " Eric Salem 0 siblings, 1 reply; 3+ messages in thread From: Joe Perches @ 2016-09-26 3:00 UTC (permalink / raw) To: Eric Salem, greg; +Cc: arve, riandrews, devel, linux-kernel On Sun, 2016-09-25 at 21:47 -0500, Eric Salem wrote: > Fixed a coding style issue. Changed symbolic permissions to octal. If you do these, please shorten the lines where possible. > diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c [] > @@ -204,10 +204,10 @@ device_initcall(lowmem_init); > * not really modular, but the easiest way to keep compat with existing > * bootargs behaviour is to continue using module_param here. > */ > -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); > +module_param_named(cost, lowmem_shrinker.seeks, int, 0644); > module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, > - S_IRUGO | S_IWUSR); > + 0644); module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, 0644); etc... ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] Staging: android: fixed permissions style issue 2016-09-26 3:00 ` Joe Perches @ 2016-09-26 3:33 ` Eric Salem 0 siblings, 0 replies; 3+ messages in thread From: Eric Salem @ 2016-09-26 3:33 UTC (permalink / raw) To: Joe Perches, greg; +Cc: arve, riandrews, devel, linux-kernel Fixed a coding style issue. Changed symbolic permissions to octal. Signed-off-by: Eric Salem <ericsalem@gmail.com> --- drivers/staging/android/lowmemorykiller.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c index 80d7adf..ec3b665 100644 --- a/drivers/staging/android/lowmemorykiller.c +++ b/drivers/staging/android/lowmemorykiller.c @@ -204,10 +204,9 @@ device_initcall(lowmem_init); * not really modular, but the easiest way to keep compat with existing * bootargs behaviour is to continue using module_param here. */ -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); -module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, - S_IRUGO | S_IWUSR); +module_param_named(cost, lowmem_shrinker.seeks, int, 0644); +module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, 0644); module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size, - S_IRUGO | S_IWUSR); -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR); + 0644); +module_param_named(debug_level, lowmem_debug_level, uint, 0644); -- 2.7.4 On 09/25/2016 10:00 PM, Joe Perches wrote: > On Sun, 2016-09-25 at 21:47 -0500, Eric Salem wrote: >> Fixed a coding style issue. Changed symbolic permissions to octal. > > If you do these, please shorten the lines where possible. > >> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c > [] >> @@ -204,10 +204,10 @@ device_initcall(lowmem_init); >> * not really modular, but the easiest way to keep compat with existing >> * bootargs behaviour is to continue using module_param here. >> */ >> -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR); >> +module_param_named(cost, lowmem_shrinker.seeks, int, 0644); >> module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, >> - S_IRUGO | S_IWUSR); >> + 0644); > > module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size, 0644); > > etc... > ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-26 3:34 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-09-26 2:47 [PATCH] Staging: android: fixed permissions style issue Eric Salem 2016-09-26 3:00 ` Joe Perches 2016-09-26 3:33 ` [PATCH v2] " Eric Salem
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.