From: james_p_freyensee@linux.intel.com (J Freyensee)
Subject: [PATCH] nvme-rdma: add missing \n to end of dev_err message
Date: Mon, 26 Sep 2016 14:53:11 -0700 [thread overview]
Message-ID: <1474926791.3078.9.camel@linux.intel.com> (raw)
In-Reply-To: <20160925220148.13300-1-colin.king@canonical.com>
On Sun, 2016-09-25@15:01 -0700, Colin King wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> Trival fix, dev_err message is missing a \n, so add it. Also
> break line as it was over 80 chars wide.
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
Reviewed-by: Jay Freyensee <james_p_freyensee at linux.intel.com>
> ---
> ?drivers/nvme/host/rdma.c | 3 ++-
> ?1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 69e1fb7..3f32995 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -1227,7 +1227,8 @@ static int nvme_rdma_conn_rejected(struct
> nvme_rdma_queue *queue,
> ? (struct nvme_rdma_cm_rej *)ev-
> >param.conn.private_data;
> ?
> ? dev_err(queue->ctrl->ctrl.device,
> - "Connect rejected, status %d.",
> le16_to_cpu(rej->sts));
> + "Connect rejected, status %d.\n",
> + le16_to_cpu(rej->sts));
> ? /* XXX: Think of something clever to do here... */
> ? } else {
> ? dev_err(queue->ctrl->ctrl.device,
WARNING: multiple messages have this Message-ID (diff)
From: J Freyensee <james_p_freyensee@linux.intel.com>
To: Colin King <colin.king@canonical.com>,
trivial@kernel.org, Keith Busch <keith.busch@intel.com>,
Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-rdma: add missing \n to end of dev_err message
Date: Mon, 26 Sep 2016 14:53:11 -0700 [thread overview]
Message-ID: <1474926791.3078.9.camel@linux.intel.com> (raw)
In-Reply-To: <20160925220148.13300-1-colin.king@canonical.com>
On Sun, 2016-09-25 at 15:01 -0700, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, dev_err message is missing a \n, so add it. Also
> break line as it was over 80 chars wide.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Jay Freyensee <james_p_freyensee@linux.intel.com>
> ---
> drivers/nvme/host/rdma.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 69e1fb7..3f32995 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -1227,7 +1227,8 @@ static int nvme_rdma_conn_rejected(struct
> nvme_rdma_queue *queue,
> (struct nvme_rdma_cm_rej *)ev-
> >param.conn.private_data;
>
> dev_err(queue->ctrl->ctrl.device,
> - "Connect rejected, status %d.",
> le16_to_cpu(rej->sts));
> + "Connect rejected, status %d.\n",
> + le16_to_cpu(rej->sts));
> /* XXX: Think of something clever to do here... */
> } else {
> dev_err(queue->ctrl->ctrl.device,
next prev parent reply other threads:[~2016-09-26 21:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 22:01 [PATCH] nvme-rdma: add missing \n to end of dev_err message Colin King
2016-09-25 22:01 ` Colin King
2016-09-26 21:53 ` J Freyensee [this message]
2016-09-26 21:53 ` J Freyensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474926791.3078.9.camel@linux.intel.com \
--to=james_p_freyensee@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.