Re: [SPDK] Is there any plan to add "quirk" mechanism to SPDK?

From: Walker, Benjamin <benjamin.walker at intel.com>
To: spdk@lists.01.org
Subject: Re: [SPDK] Is there any plan to add "quirk" mechanism to SPDK?
Date: Wed, 28 Sep 2016 16:33:25 +0000	[thread overview]
Message-ID: <1475080403.99978.4.camel@intel.com> (raw)
In-Reply-To: CAAZN+A2h7S-H50wFpYrVjHE9_exSW=9F=sQ5oZgowQSs6QygFQ@mail.gmail.com

[-- Attachment #1: Type: text/plain, Size: 1875 bytes --]

We'd love to have you submit a patch to make nvme_intel.c generic (nvme_quirks.c). Please go ahead.

On Wed, 2016-09-28 at 10:16 +0800, Wang Weber wrote:

Thanks for the information.

Is there a plan to update nvme_intel.c to be geneirc? or may I modify
it and upload the patch to the community? Thanks.

2016-09-13 0:20 GMT+08:00 Daniel Verkamp <daniel.verkamp(a)intel.com<mailto:daniel.verkamp(a)intel.com>>:

On 09/09/2016 11:03 AM, Walker, Benjamin wrote:

Currently we have no mechanism for adding device-specific quirks to the
SPDK NVMe driver. We'd certainly consider adding quirks in the same
fashion as the Linux kernel driver though, and would welcome patches
that improved the applicability of SPDK to a wider range of (potentially
out of spec) devices. I'm sure over time the team at Intel working on
SPDK will add this, but it is not on our immediate roadmap, so patches
from the community would be the best way to get this going.

Thanks,
Ben

The SPDK NVMe driver does have a quirk system that is currently used only
for Intel-specific quirks (see lib/nvme/nvme_intel.c); however, the
structure used just matches against a PCI device ID in a generic way, so we
should be able to extend this for use with other devices.

I think the ideal first patch to add such a quirk would be to rename the
nvme_intel file and structures to be generic.  Then we could add new quirk
flags to describe whatever non-spec-compliant behavior is required to make
these devices work.

Thanks,
-- Daniel

_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk

_______________________________________________
SPDK mailing list
SPDK(a)lists.01.org<mailto:SPDK(a)lists.01.org>
https://lists.01.org/mailman/listinfo/spdk

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 2305 bytes --]