From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Braun <michael-dev@fami-braun.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] mac80211: multicast to unicast conversion
Date: Fri, 30 Sep 2016 09:29:20 +0200 [thread overview]
Message-ID: <1475220560.17481.7.camel@sipsolutions.net> (raw)
In-Reply-To: <1474821596-12155-3-git-send-email-michael-dev@fami-braun.de> (sfid-20160925_184001_313936_5CD88310)
> +static ssize_t ieee80211_if_fmt_unicast(
> + const struct ieee80211_sub_if_data *sdata, char *buf, int
> buflen)
That's a very ... unusual way to break the lines here - please either
break after the first argument, or before the function name. You should
see lots of examples for both.
However, regardless of that, I don't think that debugfs is an
appropriate way to configure a production option like this.
> + int unicast;
bool, quite obviously.
> +/* rewrite destination mac address */
> +static int ieee80211_tx_dnat(struct sk_buff *skb, struct sta_info
> *sta)
How is this DNAT?
johannes
next prev parent reply other threads:[~2016-09-30 7:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 16:39 [PATCH 0/3] mac80211: multicast with AP_VLAN optimizations Michael Braun
2016-09-25 16:39 ` [PATCH 1/3] mac80211: filter multicast data packets on AP / AP_VLAN Michael Braun
2016-09-30 7:20 ` Johannes Berg
2016-09-25 16:39 ` [PATCH 2/3] mac80211: multicast to unicast conversion Michael Braun
2016-09-30 7:29 ` Johannes Berg [this message]
2016-10-04 4:36 ` M. Braun
2016-10-04 6:56 ` Johannes Berg
2016-09-25 16:39 ` [PATCH 3/3] mac80211: cache the only AP_VLAN station Michael Braun
2016-09-30 9:47 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475220560.17481.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michael-dev@fami-braun.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.