From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Braun <michael-dev@fami-braun.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] mac80211: cache the only AP_VLAN station
Date: Fri, 30 Sep 2016 11:47:58 +0200 [thread overview]
Message-ID: <1475228878.17481.10.camel@sipsolutions.net> (raw)
In-Reply-To: <1474821596-12155-4-git-send-email-michael-dev@fami-braun.de> (sfid-20160925_184003_115938_F92E1D65)
On Sun, 2016-09-25 at 18:39 +0200, Michael Braun wrote:
> If an AP_VLAN is only used with one station, cache a pointer to this
> station to avoid lookup. This should speed up station lookup when
"should speed up"? Do you have numbers to back that up?
Read this as - you need to do more to convince me that the double
accounting and software complexity is worth it.
And then, if we really want/need to have the double accounting and all
the associated complexity and potential problems, perhaps making per-
interface lists, perhaps even replacing the global list (since we still
have a global hash table), or something similar would make more sense?
johannes
prev parent reply other threads:[~2016-09-30 9:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 16:39 [PATCH 0/3] mac80211: multicast with AP_VLAN optimizations Michael Braun
2016-09-25 16:39 ` [PATCH 1/3] mac80211: filter multicast data packets on AP / AP_VLAN Michael Braun
2016-09-30 7:20 ` Johannes Berg
2016-09-25 16:39 ` [PATCH 2/3] mac80211: multicast to unicast conversion Michael Braun
2016-09-30 7:29 ` Johannes Berg
2016-10-04 4:36 ` M. Braun
2016-10-04 6:56 ` Johannes Berg
2016-09-25 16:39 ` [PATCH 3/3] mac80211: cache the only AP_VLAN station Michael Braun
2016-09-30 9:47 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475228878.17481.10.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=michael-dev@fami-braun.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.