All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "usb: musb: Fix DMA desired mode for Mentor DMA engine" has been added to the 4.4-stable tree
@ 2016-10-04  8:17 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-10-04  8:17 UTC (permalink / raw)
  To: cristian.birsan, aford173, balbi, gregkh, joshua.henderson,
	sergei.shtylyov, tony
  Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    usb: musb: Fix DMA desired mode for Mentor DMA engine

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     usb-musb-fix-dma-desired-mode-for-mentor-dma-engine.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From bba40e6948b94cba71965285fbac31bd078c024a Mon Sep 17 00:00:00 2001
From: Cristian Birsan <cristian.birsan@microchip.com>
Date: Thu, 11 Feb 2016 08:58:17 -0700
Subject: usb: musb: Fix DMA desired mode for Mentor DMA engine

From: Cristian Birsan <cristian.birsan@microchip.com>

commit bba40e6948b94cba71965285fbac31bd078c024a upstream.

Commit 754fe4a92c07 ("usb: musb: Remove ifdefs for TX DMA for musb_host.c")
introduces a problem setting the desired channel mode for the Mentor DMA
engine.

There is a case where an address is incorrectly assigned to the DMA
channel desired mode when it should instead be assigned the actual mode
value. This results in the value of channel->desired_mode not being
correct.

Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Cc: Adam Ford <aford173@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/usb/musb/musb_host.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -661,7 +661,7 @@ static int musb_tx_dma_set_mode_mentor(s
 		csr &= ~(MUSB_TXCSR_AUTOSET | MUSB_TXCSR_DMAMODE);
 		csr |= MUSB_TXCSR_DMAENAB; /* against programmer's guide */
 	}
-	channel->desired_mode = mode;
+	channel->desired_mode = *mode;
 	musb_writew(epio, MUSB_TXCSR, csr);
 
 	return 0;


Patches currently in stable-queue which might be from cristian.birsan@microchip.com are

queue-4.4/usb-musb-fix-dma-for-host-mode.patch
queue-4.4/usb-musb-fix-dma-desired-mode-for-mentor-dma-engine.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-10-04  8:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-04  8:17 Patch "usb: musb: Fix DMA desired mode for Mentor DMA engine" has been added to the 4.4-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.