From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
Mark Hatle <mark.hatle@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 0/9] Add MIPS release 6 ISA support
Date: Fri, 07 Oct 2016 17:19:49 +0100 [thread overview]
Message-ID: <1475857189.30475.639.camel@linuxfoundation.org> (raw)
In-Reply-To: <0e93c6bb-0b30-c203-5750-f470e2753f7c@imgtec.com>
On Fri, 2016-10-07 at 17:07 +0100, Zubair Lutfullah Kakakhel wrote:
> On 10/07/2016 04:48 PM, Richard Purdie wrote:
> > On Fri, 2016-10-07 at 12:53 +0100, Zubair Lutfullah Kakakhel wrote:
> > What I will say though is that we really need to think about an
> > "allmips", or "mipsarch" override, rather than all these duplicate
> > lines for all mips variants. This is something we should fix early
> > in
> > the 2.3 cycle and should make some of this look a lot neater. It
> > might
> > be worth openening a bug for this in the bugzilla and assigning
> > that to
> > yourself, assuming you're happy to work on it?
> The duplicate lines are bothersome indeed.
> I'm happy to work on it. But I'm still a bit new to OE internals so
> would
> prefer a little direction regarding the best approach to take.
Very roughly speaking, you'd add something like:
MACHINEOVERRIDES =. "mipsarch"
to arch-mips.inc then you could do:
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 54a587f..7bd8716 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -528,16 +528,7 @@ BUILDSDK_LDFLAGS = "-Wl,-O1"
LINKER_HASH_STYLE ??= "gnu"
# mips does not support GNU hash style therefore we override
-LINKER_HASH_STYLE_mips = "sysv"
-LINKER_HASH_STYLE_mipsel = "sysv"
-LINKER_HASH_STYLE_mips64 = "sysv"
-LINKER_HASH_STYLE_mips64el = "sysv"
-LINKER_HASH_STYLE_mips64n32 = "sysv"
-LINKER_HASH_STYLE_mips64eln32 = "sysv"
-LINKER_HASH_STYLE_mipsisa32r6 = "sysv"
-LINKER_HASH_STYLE_mipsisa32r6el = "sysv"
-LINKER_HASH_STYLE_mipsisa64r6 = "sysv"
-LINKER_HASH_STYLE_mipsisa64r6el = "sysv"
+LINKER_HASH_STYLE_mipsarch = "sysv"
TARGET_LINK_HASH_STYLE ?= "${@['-Wl,--hash-style=gnu',''][d.getVar('LINKER_HASH_STYLE', True) != 'gnu']}"
amongst other nice cleanups.
Cheers,
Richard
next prev parent reply other threads:[~2016-10-07 16:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 11:31 [PATCH 0/9] Add MIPS release 6 ISA support Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 1/9] insane.bbclass: Add mipsisa{32, 64}r6{el, } Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 2/9] kernel-arch.bbclass: Add mipsisa{32, 64}r6{el, } support Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 3/9] libc-package.bbclass: " Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 4/9] linuxloader.bbclass: " Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 5/9] siteinfo.bbclass: " Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 6/9] bitbake.conf: " Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 7/9] glibc: " Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 8/9] gcc-configure: " Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 9/9] arch-mips: Add mipsisa{32, 64}r6{el, } tunes Zubair Lutfullah Kakakhel
2016-10-06 16:43 ` [PATCH 0/9] Add MIPS release 6 ISA support Mark Hatle
2016-10-07 11:53 ` Zubair Lutfullah Kakakhel
2016-10-07 15:48 ` Richard Purdie
2016-10-07 16:07 ` Zubair Lutfullah Kakakhel
2016-10-07 16:19 ` Richard Purdie [this message]
2016-10-07 16:21 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475857189.30475.639.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.