From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
Mark Hatle <mark.hatle@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 0/9] Add MIPS release 6 ISA support
Date: Fri, 07 Oct 2016 16:48:38 +0100 [thread overview]
Message-ID: <1475855318.30475.633.camel@linuxfoundation.org> (raw)
In-Reply-To: <77aabb0f-ae71-2425-6a63-fabd27bed710@imgtec.com>
On Fri, 2016-10-07 at 12:53 +0100, Zubair Lutfullah Kakakhel wrote:
> On 10/06/2016 05:43 PM, Mark Hatle wrote:
> >
> > A few general comments. I don't see an n32 variant
> > implemented. I'd suggest a
> > follow on patch (vs a new version) to add n32.
> >
> > It looks like it's missing in the files modified by patches 6-9.
> Thanks for the review.
> Yes I haven't added the n32 variant on purpose at the moment.
> Wanted to get this out to see if this is the correct approach.
I've been torn on these patches, they're good but they've come in very
late in the cycle for this kind of change. Since they're comparatively
straight forward to review, I've merged them. This is partly because I
wouldn't really want to backport changes like this later and it seemed
likely that might be requested.
What I will say though is that we really need to think about an
"allmips", or "mipsarch" override, rather than all these duplicate
lines for all mips variants. This is something we should fix early in
the 2.3 cycle and should make some of this look a lot neater. It might
be worth openening a bug for this in the bugzilla and assigning that to
yourself, assuming you're happy to work on it?
Cheers,
Richard
next prev parent reply other threads:[~2016-10-07 15:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 11:31 [PATCH 0/9] Add MIPS release 6 ISA support Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 1/9] insane.bbclass: Add mipsisa{32, 64}r6{el, } Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 2/9] kernel-arch.bbclass: Add mipsisa{32, 64}r6{el, } support Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 3/9] libc-package.bbclass: " Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 4/9] linuxloader.bbclass: " Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 5/9] siteinfo.bbclass: " Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 6/9] bitbake.conf: " Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 7/9] glibc: " Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 8/9] gcc-configure: " Zubair Lutfullah Kakakhel
2016-10-04 11:31 ` [PATCH 9/9] arch-mips: Add mipsisa{32, 64}r6{el, } tunes Zubair Lutfullah Kakakhel
2016-10-06 16:43 ` [PATCH 0/9] Add MIPS release 6 ISA support Mark Hatle
2016-10-07 11:53 ` Zubair Lutfullah Kakakhel
2016-10-07 15:48 ` Richard Purdie [this message]
2016-10-07 16:07 ` Zubair Lutfullah Kakakhel
2016-10-07 16:19 ` Richard Purdie
2016-10-07 16:21 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475855318.30475.633.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.