[PATCH] check bitbake server-only port is a number

[PATCH] check bitbake server-only port is a number

[Benjamin Esquivel]

either using the memres script or the bitbake call with --server-only
if the port is a string instead of a number then the process hangs
indefinitely causing a loop that never ends.

adding a check at the beginning for the port being a number otherwise
end prematurely.

[YOCTO#10397]

Signed-off-by: Benjamin Esquivel <benjamin.esquivel@linux.intel.com>
---
 bitbake/lib/bb/main.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/bitbake/lib/bb/main.py b/bitbake/lib/bb/main.py
index 7f7d87b..f2f59f6 100755
--- a/bitbake/lib/bb/main.py
+++ b/bitbake/lib/bb/main.py
@@ -402,6 +402,13 @@ def bitbake_main(configParams, configuration):
         if not configParams.bind:
             raise BBMainException("FATAL: The '--server-only' option requires a name/address "
                                   "to bind to with the -B option.\n")
+        else:
+            try:
+                #Checking that the port is a number
+                int(configParams.bind.split(":")[1])
+            except (ValueError,IndexError):
+                raise BBMainException(
+                        "FATAL: Malformed host:port bind parameter")
         if configParams.remote_server:
             raise BBMainException("FATAL: The '--server-only' option conflicts with %s.\n" %
                                   ("the BBSERVER environment variable" if "BBSERVER" in os.environ \
-- 
2.7.4

Re: [PATCH] check bitbake server-only port is a number

[Richard Purdie]

On Fri, 2016-10-07 at 16:46 -0500, Benjamin Esquivel wrote:
> either using the memres script or the bitbake call with --server-only
> if the port is a string instead of a number then the process hangs
> indefinitely causing a loop that never ends.
> 
> adding a check at the beginning for the port being a number otherwise
> end prematurely.
> 
> [YOCTO#10397]
> 
> Signed-off-by: Benjamin Esquivel <benjamin.esquivel@linux.intel.com>
> ---
>  bitbake/lib/bb/main.py | 7 +++++++
>  1 file changed, 7 insertions(+)

bitbake patches should go to the bitbake list. I've queued this anyway
since I don't like indefinite hangs. I also had to tweak the commit
message (e.g. a main: prefix to the shortlog).

Cheers,

Richard