Re: [PATCH 1/1] x86/platform/intel-mid: Retrofit pci_platform_pm_ops ->get_power hook

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Sun, 2016-10-09 at 12:46 +0200, Lukas Wunner wrote:
> On Fri, Oct 07, 2016 at 11:55:34PM +0300, Andy Shevchenko wrote:
> > 
> > On Thu, 2016-10-06 at 08:24 +0200, Lukas Wunner wrote:
> > > 
> > > +
> > > +	reg = (id * LSS_PWS_BITS) / 32;
> > > +	bit = (id * LSS_PWS_BITS) % 32;
> > > +	power = mid_pwr_get_state(pwr, reg);
> > > +	return (power >> bit) & 3;
> > 
> > Don't add sparse warnings:
> > 
> >         return (__force pci_power_t)((power >> bit) & 3);
> 
> I do not get any different sparse warnings with or without the cast
> despite using -Wsparse-all.  This is with sparse 0.5.0 as included in
> Debian stretch.
> 
> With which options and sparse version did you manage to get new
> warnings?

$ sparse --version
v0.5.0

$ make C=1 CF=-D__CHECK_ENDIAN__ W=1 -j64 

Warning itself:

arch/x86/platform/intel-mid/pwr.c:305:31: warning: incorrect type in
return expression (different base types)
arch/x86/platform/intel-mid/pwr.c:305:31:    expected restricted
pci_power_t
arch/x86/platform/intel-mid/pwr.c:305:31:    got unsigned int


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy