From: Lukas Wunner <lukas@wunner.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, x86@kernel.org
Subject: [PATCH 0/1] x86/platform/intel-mid: Retrofit pci_platform_pm_ops
Date: Thu, 6 Oct 2016 08:24:29 +0200 [thread overview]
Message-ID: <cover.1475733022.git.lukas@wunner.de> (raw)
Somehow it went completely under my radar that v4.8 added another
struct pci_platform_pm_ops for Intel Mobile Internet Devices.
There's a commit queued for v4.9 on Bjorn's pci/pm branch which adds
a mandatory ->get_power hook to pci_platform_pm_ops and implements
it for acpi_pci_platform_pm, but not mid_pci_platform_pm.
The following patch fixes that. It's not a build issue, the missing
hook in mid_pci_platform_pm only becomes a problem at runtime.
@Andy: Could you look over this and provide an ack? I do not have
an Intel MID so I was only able to compile-test the patch.
The ->get_power hook is currently only called to update a device's
current_state after resume (both at runtime and after system sleep)
and after changing its power state using the platform in
pci_platform_power_transition(). The result of the ->get_power hook
is ignored unless it's D3cold. Since intel-mid PCI devices can only
be suspended to D3hot, the return value is irrelevant on this platform,
the hook just needs to be present to make pci_set_platform_pm() happy.
If you want to test the patch, you need to apply it either on Bjorn's
pci/pm branch or linux-next:
http://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/log/?h=pci/pm
Thanks,
Lukas
Lukas Wunner (1):
x86/platform/intel-mid: Retrofit pci_platform_pm_ops ->get_power hook
arch/x86/include/asm/intel-mid.h | 1 +
arch/x86/platform/intel-mid/pwr.c | 19 +++++++++++++++++++
drivers/pci/pci-mid.c | 6 ++++++
3 files changed, 26 insertions(+)
--
2.9.3
next reply other threads:[~2016-10-06 6:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 6:24 Lukas Wunner [this message]
2016-10-06 6:24 ` [PATCH 1/1] x86/platform/intel-mid: Retrofit pci_platform_pm_ops ->get_power hook Lukas Wunner
2016-10-07 20:55 ` Andy Shevchenko
2016-10-08 13:49 ` Lukas Wunner
2016-10-09 12:26 ` Andy Shevchenko
2016-10-09 15:03 ` Lukas Wunner
2016-10-10 10:54 ` Andy Shevchenko
2016-10-09 10:46 ` Lukas Wunner
2016-10-09 11:57 ` Andy Shevchenko
2016-10-09 12:49 ` Lukas Wunner
2016-10-07 20:55 ` [PATCH 0/1] x86/platform/intel-mid: Retrofit pci_platform_pm_ops Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1475733022.git.lukas@wunner.de \
--to=lukas@wunner.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.