All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harman Kalra <harman4linux@gmail.com>
To: gregkh@linuxfoundation.org, sudipm.mukherjee@gmail.com
Cc: bankarsandhya512@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org,
	Harman Kalra <harman4linux@gmail.com>
Subject: [PATCH] Staging: i4l: act2000: Fixed warning "use pr_* instead of printk"
Date: Sun,  9 Oct 2016 20:29:11 +0530	[thread overview]
Message-ID: <1476025151-9645-1-git-send-email-harman4linux@gmail.com> (raw)
In-Reply-To: <20161009145134.GA9324@tuxzone>

This patch replaces calls to the "printk" with  appropriate "pr_*"
function thus addressing the following warning generated by the
checkpatch script:

Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
        dev_warn(dev, ... then pr_warn(...  to printk(KERN_WARNING ...:w

Signed-off-by: Harman Kalra <harman4linux@gmail.com>
---
 drivers/staging/i4l/act2000/act2000_isa.c |   25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/drivers/staging/i4l/act2000/act2000_isa.c b/drivers/staging/i4l/act2000/act2000_isa.c
index ad7a039..76195b9 100644
--- a/drivers/staging/i4l/act2000/act2000_isa.c
+++ b/drivers/staging/i4l/act2000/act2000_isa.c
@@ -78,10 +78,10 @@
 	if (istatus & ISA_ISR_ERR) {
 		/* Error Interrupt */
 		istatus &= ISA_ISR_ERR_MASK;
-		printk(KERN_WARNING "act2000: errIRQ\n");
+		pr_warn("act2000: errIRQ\n");
 	}
 	if (istatus)
-		printk(KERN_DEBUG "act2000: ?IRQ %d %02x\n", card->irq, istatus);
+		pr_debug("act2000: ?IRQ %d %02x\n", card->irq, istatus);
 	return IRQ_HANDLED;
 }
 
@@ -147,8 +147,7 @@
 	if (request_irq(irq, &act2000_isa_interrupt, 0, card->regname, card)) {
 		card->irq = old_irq;
 		card->flags |= ACT2000_FLAGS_IVALID;
-		printk(KERN_WARNING
-		       "act2000: Could not request irq %d\n", irq);
+		pr_warn("act2000: Could not request irq %d\n", irq);
 		return -EBUSY;
 	} else {
 		act2000_isa_select_irq(card);
@@ -246,8 +245,7 @@
 					card->idat.isa.rcvskb = dev_alloc_skb(card->idat.isa.rcvlen);
 					if (!card->idat.isa.rcvskb) {
 						card->idat.isa.rcvignore = 1;
-						printk(KERN_WARNING
-						       "act2000_isa_receive: no memory\n");
+						pr_warn("act2000_isa_receive: no memory\n");
 						test_and_clear_bit(ACT2000_LOCK_RX, (void *)&card->ilock);
 						return;
 					}
@@ -255,13 +253,12 @@
 					card->idat.isa.rcvptr = skb_put(card->idat.isa.rcvskb, card->idat.isa.rcvlen - 8);
 				} else {
 					card->idat.isa.rcvidx = 0;
-					printk(KERN_WARNING
-					       "act2000_isa_receive: Invalid CAPI msg\n");
+					pr_warn("act2000_isa_receive: Invalid CAPI msg\n");
 					{
 						int i; __u8 *p; __u8 *t; __u8 tmp[30];
 						for (i = 0, p = (__u8 *)&card->idat.isa.rcvhdr, t = tmp; i < 8; i++)
 							t += sprintf(t, "%02x ", *(p++));
-						printk(KERN_WARNING "act2000_isa_receive: %s\n", tmp);
+						pr_warn("act2000_isa_receive: %s\n", tmp);
 					}
 				}
 			}
@@ -370,21 +367,21 @@
 		count++;
 	}
 	if (count <= 20) {
-		printk(KERN_WARNING "act2000: No Firmware-ID!\n");
+		pr_warn("act2000: No Firmware-ID!\n");
 		return -ETIME;
 	}
 	*p = '\0';
 	fid.revlen[0] = '\0';
 	if (strcmp(fid.isdn, "ISDN")) {
-		printk(KERN_WARNING "act2000: Wrong Firmware-ID!\n");
+		pr_warn("act2000: Wrong Firmware-ID!\n");
 		return -EPROTO;
 	}
 	p = strchr(fid.revision, '\n');
 	if (p)
 		*p = '\0';
-	printk(KERN_INFO "act2000: Firmware-ID: %s\n", fid.revision);
+	pr_info("act2000: Firmware-ID: %s\n", fid.revision);
 	if (card->flags & ACT2000_FLAGS_IVALID) {
-		printk(KERN_DEBUG "Enabling Interrupts ...\n");
+		pr_debug("Enabling Interrupts ...\n");
 		act2000_isa_enable_irq(card);
 	}
 	return 0;
@@ -426,7 +423,7 @@
 		}
 		while (c < l) {
 			if (act2000_isa_writeb(card, *b++)) {
-				printk(KERN_WARNING
+				pr_warn(
 				       "act2000: loader timed out"
 				       " len=%d c=%d\n", length, c);
 				kfree(buf);
-- 
1.7.9.5

       reply	other threads:[~2016-10-09 14:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161009145134.GA9324@tuxzone>
2016-10-09 14:59 ` Harman Kalra [this message]
2016-10-09 15:21   ` [PATCH] Staging: i4l: act2000: Fixed warning "use pr_* instead of printk" Greg KH
2016-10-09 14:28 Harman Kalra
2016-10-09 14:40 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476025151-9645-1-git-send-email-harman4linux@gmail.com \
    --to=harman4linux@gmail.com \
    --cc=bankarsandhya512@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.