All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Harman Kalra <harman4linux@gmail.com>
Cc: sudipm.mukherjee@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, bankarsandhya512@gmail.com
Subject: Re: [PATCH] Staging: i4l: act2000: Fixed warning "use pr_* instead of printk"
Date: Sun, 9 Oct 2016 17:21:35 +0200	[thread overview]
Message-ID: <20161009152135.GB5801@kroah.com> (raw)
In-Reply-To: <1476025151-9645-1-git-send-email-harman4linux@gmail.com>

On Sun, Oct 09, 2016 at 08:29:11PM +0530, Harman Kalra wrote:
> This patch replaces calls to the "printk" with  appropriate "pr_*"
> function thus addressing the following warning generated by the
> checkpatch script:
> 
> Prefer [subsystem eg: netdev]_warn([subsystem]dev, ... then
>         dev_warn(dev, ... then pr_warn(...  to printk(KERN_WARNING ...:w
> 
> Signed-off-by: Harman Kalra <harman4linux@gmail.com>
> ---
>  drivers/staging/i4l/act2000/act2000_isa.c |   25 +++++++++++--------------
>  1 file changed, 11 insertions(+), 14 deletions(-)

This is a new version of the patch, so you need to version it, see the
file, Documentation/SubmittingPatches for all of the details on how to
do that properly.

thanks,

greg k-h

  reply	other threads:[~2016-10-09 15:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161009145134.GA9324@tuxzone>
2016-10-09 14:59 ` [PATCH] Staging: i4l: act2000: Fixed warning "use pr_* instead of printk" Harman Kalra
2016-10-09 15:21   ` Greg KH [this message]
2016-10-09 14:28 Harman Kalra
2016-10-09 14:40 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161009152135.GB5801@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bankarsandhya512@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=harman4linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.