From: Shyam Saini <mayhs11saini@gmail.com>
To: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] gpu: drm: gma500: Use vma_pages()
Date: Mon, 10 Oct 2016 07:22:47 +0530 [thread overview]
Message-ID: <1476064367.14200.0.camel@gmail.com> (raw)
In-Reply-To: <CAMeQTsbANnW5wg=5RO4mNPsR1kvqD-h_H-GkatG53nMqVFzoig@mail.gmail.com>
On Mon, 2016-10-10 at 01:46 +0200, Patrik Jakobsson wrote:
> On Mon, Oct 10, 2016 at 1:07 AM, Shyam Saini <mayhs11saini@gmail.com>
> wrote:
> >
> > Replace explicit computation of vma page count by a call to
> > vma_pages()
> Hi, I already have this patch in the "queue" from:
> Muhammad Falak R Wani <falakreyaz@gmail.com>
>
> Will include that one when I get around to sending out a PR.
>
> Thanks
> Patrik
>
> >
> >
> > Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
> > ---
> > drivers/gpu/drm/gma500/framebuffer.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/gma500/framebuffer.c
> > b/drivers/gpu/drm/gma500/framebuffer.c
> > index 3a44e70..0fde850 100644
> > --- a/drivers/gpu/drm/gma500/framebuffer.c
> > +++ b/drivers/gpu/drm/gma500/framebuffer.c
> > @@ -124,7 +124,7 @@ static int psbfb_vm_fault(struct vm_area_struct
> > *vma, struct vm_fault *vmf)
> > unsigned long phys_addr = (unsigned long)dev_priv-
> > >stolen_base +
> > psbfb->gtt->offset;
> >
> > - page_num = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
> > + page_num = vma_pages(vma);
> > address = (unsigned long)vmf->virtual_address - (vmf->pgoff
> > << PAGE_SHIFT);
> >
> > vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
> > --
> > 2.7.4
> >
No issue.
Thanks
next prev parent reply other threads:[~2016-10-10 1:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 23:07 [PATCH 1/1] gpu: drm: gma500: Use vma_pages() Shyam Saini
2016-10-09 23:46 ` Patrik Jakobsson
2016-10-09 23:46 ` Patrik Jakobsson
2016-10-10 1:52 ` Shyam Saini [this message]
2016-10-11 8:15 ` Daniel Vetter
2016-10-11 8:15 ` Daniel Vetter
2016-10-11 8:50 ` Patrik Jakobsson
2016-10-11 8:50 ` Patrik Jakobsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476064367.14200.0.camel@gmail.com \
--to=mayhs11saini@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.