From: Dennis Kaarsemaker <dennis@kaarsemaker.net>
To: "Mantas Mikulėnas" <grawity@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] contrib: add credential helper for libsecret
Date: Tue, 11 Oct 2016 17:01:20 +0200 [thread overview]
Message-ID: <1476198080.3876.8.camel@kaarsemaker.net> (raw)
In-Reply-To: <20161009123417.147239-1-grawity@gmail.com>
On Sun, 2016-10-09 at 15:34 +0300, Mantas Mikulėnas wrote:
> + s = g_hash_table_lookup(attributes, "user");
> + if (s) {
> + g_free(c->username);
> + c->username = g_strdup(s);
> + }
This always overwrites c->username, the original gnome-keyring version
only does that when the username isn't set. Other than that it looks
good to me.
Reviewed-by: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Tested-by: Dennis Kaarsemaker <dennis@kaarsemaker.net>
D.
next prev parent reply other threads:[~2016-10-11 15:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 12:34 [PATCH] contrib: add credential helper for libsecret Mantas Mikulėnas
2016-10-10 18:34 ` Jeff King
2016-10-10 20:20 ` Dennis Kaarsemaker
2016-10-10 20:46 ` Jeff King
2016-10-11 15:01 ` Dennis Kaarsemaker
2016-10-11 15:01 ` Dennis Kaarsemaker [this message]
2016-10-11 19:36 ` Junio C Hamano
2016-10-11 19:48 ` Mantas Mikulėnas
2016-10-11 19:59 ` Mantas Mikulėnas
2016-10-11 20:09 ` Dennis Kaarsemaker
2016-10-11 20:13 ` Junio C Hamano
2016-10-11 20:19 ` Junio C Hamano
2016-10-11 20:32 ` Dennis Kaarsemaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476198080.3876.8.camel@kaarsemaker.net \
--to=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
--cc=grawity@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.