From: Junio C Hamano <gitster@pobox.com>
To: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Cc: "Mantas Mikulėnas" <grawity@gmail.com>,
git@vger.kernel.org, "Brandon Casey" <drafnel@gmail.com>
Subject: Re: [PATCH] contrib: add credential helper for libsecret
Date: Tue, 11 Oct 2016 13:13:37 -0700 [thread overview]
Message-ID: <xmqqa8ea8wzy.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <1476216585.3876.10.camel@kaarsemaker.net> (Dennis Kaarsemaker's message of "Tue, 11 Oct 2016 22:09:45 +0200")
Dennis Kaarsemaker <dennis@kaarsemaker.net> writes:
> On Tue, 2016-10-11 at 22:48 +0300, Mantas Mikulėnas wrote:
>> On 2016-10-11 22:36, Junio C Hamano wrote:
>> > Thanks for a review. I'll wait until one of (1) a squashable patch
>> > to address the "we do not want unconditional overwrite" issue, (2) a
>> > reroll from Mantas to do the same, or (3) a counter-argument from
>> > somebody to explain why unconditional overwrite is a good idea here
>> > (but not in the original) appears.
>>
>>
>> I overlooked that. I can write a patch, but it shouldn't make any
>> difference in practice – if c->username *was* set, then it would also
>> get added to the search attribute list, therefore the search couldn't
>> possibly return any results with a different username anyway.
>
> Makes sense, so a (3) it is.
So... does it mean the gnome-keyring one needs a bugfix?
next prev parent reply other threads:[~2016-10-11 20:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 12:34 [PATCH] contrib: add credential helper for libsecret Mantas Mikulėnas
2016-10-10 18:34 ` Jeff King
2016-10-10 20:20 ` Dennis Kaarsemaker
2016-10-10 20:46 ` Jeff King
2016-10-11 15:01 ` Dennis Kaarsemaker
2016-10-11 15:01 ` Dennis Kaarsemaker
2016-10-11 19:36 ` Junio C Hamano
2016-10-11 19:48 ` Mantas Mikulėnas
2016-10-11 19:59 ` Mantas Mikulėnas
2016-10-11 20:09 ` Dennis Kaarsemaker
2016-10-11 20:13 ` Junio C Hamano [this message]
2016-10-11 20:19 ` Junio C Hamano
2016-10-11 20:32 ` Dennis Kaarsemaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqa8ea8wzy.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=dennis@kaarsemaker.net \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=grawity@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.