From: Joe Perches <joe@perches.com>
To: Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jdelvare@suse.com, wsa@the-dreams.de
Subject: Re: [PATCH 5/5] i2c: i2c-piix4: coding style fix - quoted string split across lines
Date: Tue, 11 Oct 2016 19:03:56 -0700 [thread overview]
Message-ID: <1476237836.2116.8.camel@perches.com> (raw)
In-Reply-To: <20161011173455.7803-1-palminha@synopsys.com>
On Tue, 2016-10-11 at 18:34 +0100, Carlos Palminha wrote:
[]
> diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
[]
> @@ -260,7 +260,8 @@ static int piix4_setup(struct pci_dev *PIIX4_dev,
> else if ((temp & 0x0E) == 0)
> dev_dbg(&PIIX4_dev->dev, "Using SMI# for SMBus\n");
> else
> - dev_err(&PIIX4_dev->dev, "Illegal Interrupt configuration "
> + dev_err(&PIIX4_dev->dev,
> + "Illegal Interrupt configuration "
> "(or code out of date)!\n");
typically, this format would be coalesced into a single line.
next prev parent reply other threads:[~2016-10-12 2:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 17:24 [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes Carlos Palminha
2016-10-11 17:24 ` Carlos Palminha
2016-10-11 17:24 ` [PATCH 1/5] i2c: i2c-piix4: coding style fix - '*' adjacent to data name Carlos Palminha
2016-10-11 17:24 ` Carlos Palminha
2016-10-11 17:24 ` [PATCH 2/5] i2c: i2c-piix4: coding style fix - assignment in if condition Carlos Palminha
2016-10-11 17:24 ` Carlos Palminha
2016-10-11 17:24 ` [PATCH 3/5] i2c: i2c-piix4: coding style fix - long comments blocks Carlos Palminha
2016-10-11 17:24 ` Carlos Palminha
2016-10-13 11:30 ` Jean Delvare
2016-10-13 11:30 ` Jean Delvare
2016-10-11 17:24 ` [PATCH 4/5] i2c: i2c-piix4: coding style fix - spaces with open parenthesis Carlos Palminha
2016-10-11 17:24 ` Carlos Palminha
2016-10-11 17:34 ` [PATCH 5/5] i2c: i2c-piix4: coding style fix - quoted string split across lines Carlos Palminha
2016-10-11 17:34 ` Carlos Palminha
2016-10-12 2:03 ` Joe Perches [this message]
2016-10-13 11:34 ` Jean Delvare
2016-10-13 11:40 ` [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes Jean Delvare
2016-10-13 11:40 ` Jean Delvare
2016-10-13 16:44 ` Carlos Palminha
2016-10-13 16:44 ` Carlos Palminha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476237836.2116.8.camel@perches.com \
--to=joe@perches.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.