From: Jean Delvare <jdelvare@suse.de>
To: Carlos Palminha <CARLOS.PALMINHA@synopsys.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
wsa@the-dreams.de
Subject: Re: [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes
Date: Thu, 13 Oct 2016 13:40:29 +0200 [thread overview]
Message-ID: <20161013134029.1828048b@endymion> (raw)
In-Reply-To: <20161011172441.7422-1-palminha@synopsys.com>
Hi Carlos,
On Tue, 11 Oct 2016 18:24:36 +0100, Carlos Palminha wrote:
> This patchset fixes several coding style issues.
>
> Carlos Palminha (5):
> i2c: i2c-piix4: coding style fix - '*' adjacent to data name
> i2c: i2c-piix4: coding style fix - assignment in if condition
> i2c: i2c-piix4: coding style fix - long comments blocks
> i2c: i2c-piix4: coding style fix - spaces with open parenthesis
> i2c: i2c-piix4: coding style fix - quoted string split across lines
>
> drivers/i2c/busses/i2c-piix4.c | 144 +++++++++++++++++++++++------------------
> 1 file changed, 82 insertions(+), 62 deletions(-)
Except for the two issues which were already pointed out, I'm fine with
these changes, however there is no good reason to split them into 5
separate patches. Fixing the coding style is one goal, it should be all
done with a single patch. So, when you resubmit, please do so as a
single patch.
Thanks,
--
Jean Delvare
SUSE L3 Support
WARNING: multiple messages have this Message-ID (diff)
From: Jean Delvare <jdelvare@suse.de>
To: Carlos Palminha <CARLOS.PALMINHA@synopsys.com>
Cc: <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<wsa@the-dreams.de>
Subject: Re: [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes
Date: Thu, 13 Oct 2016 13:40:29 +0200 [thread overview]
Message-ID: <20161013134029.1828048b@endymion> (raw)
In-Reply-To: <20161011172441.7422-1-palminha@synopsys.com>
Hi Carlos,
On Tue, 11 Oct 2016 18:24:36 +0100, Carlos Palminha wrote:
> This patchset fixes several coding style issues.
>
> Carlos Palminha (5):
> i2c: i2c-piix4: coding style fix - '*' adjacent to data name
> i2c: i2c-piix4: coding style fix - assignment in if condition
> i2c: i2c-piix4: coding style fix - long comments blocks
> i2c: i2c-piix4: coding style fix - spaces with open parenthesis
> i2c: i2c-piix4: coding style fix - quoted string split across lines
>
> drivers/i2c/busses/i2c-piix4.c | 144 +++++++++++++++++++++++------------------
> 1 file changed, 82 insertions(+), 62 deletions(-)
Except for the two issues which were already pointed out, I'm fine with
these changes, however there is no good reason to split them into 5
separate patches. Fixing the coding style is one goal, it should be all
done with a single patch. So, when you resubmit, please do so as a
single patch.
Thanks,
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-10-13 11:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 17:24 [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes Carlos Palminha
2016-10-11 17:24 ` Carlos Palminha
2016-10-11 17:24 ` [PATCH 1/5] i2c: i2c-piix4: coding style fix - '*' adjacent to data name Carlos Palminha
2016-10-11 17:24 ` Carlos Palminha
2016-10-11 17:24 ` [PATCH 2/5] i2c: i2c-piix4: coding style fix - assignment in if condition Carlos Palminha
2016-10-11 17:24 ` Carlos Palminha
2016-10-11 17:24 ` [PATCH 3/5] i2c: i2c-piix4: coding style fix - long comments blocks Carlos Palminha
2016-10-11 17:24 ` Carlos Palminha
2016-10-13 11:30 ` Jean Delvare
2016-10-13 11:30 ` Jean Delvare
2016-10-11 17:24 ` [PATCH 4/5] i2c: i2c-piix4: coding style fix - spaces with open parenthesis Carlos Palminha
2016-10-11 17:24 ` Carlos Palminha
2016-10-11 17:34 ` [PATCH 5/5] i2c: i2c-piix4: coding style fix - quoted string split across lines Carlos Palminha
2016-10-11 17:34 ` Carlos Palminha
2016-10-12 2:03 ` Joe Perches
2016-10-13 11:34 ` Jean Delvare
2016-10-13 11:40 ` Jean Delvare [this message]
2016-10-13 11:40 ` [PATCH 0/5] i2c: i2c-piix4: set of coding style fixes Jean Delvare
2016-10-13 16:44 ` Carlos Palminha
2016-10-13 16:44 ` Carlos Palminha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161013134029.1828048b@endymion \
--to=jdelvare@suse.de \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.