From: Johannes Berg <johannes@sipsolutions.net>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: herbert@gondor.apana.org.au, sergey.senozhatsky.work@gmail.com
Subject: Re: [PATCH v4] mac80211: move struct aead_req off the stack
Date: Mon, 17 Oct 2016 16:17:08 +0200 [thread overview]
Message-ID: <1476713828.315.5.camel@sipsolutions.net> (raw)
In-Reply-To: <1476713133-18355-1-git-send-email-ard.biesheuvel@linaro.org> (sfid-20161017_160545_826866_8595CA02)
On Mon, 2016-10-17 at 15:05 +0100, Ard Biesheuvel wrote:
> From: Johannes Berg <johannes.berg@intel.com>
That really ought to have been you - I think I may have lost that by
accident. I'll change it.
> In addition, take care not to put any of our own stack allocations
> into
> scatterlists. This involves reserving some extra room when allocating
> the
> aead_request structures, and referring to those allocations in the
> scatter-
> lists (while copying the data from/to the stack before/after the
> crypto
> operation, as appropriate)
I removed the "to the stack after" language, since that doesn't
actually occur :)
> --- a/net/mac80211/aes_cmac.h
> +++ b/net/mac80211/aes_cmac.h
> @@ -11,6 +11,8 @@
>
> #include <linux/crypto.h>
>
> +#define CMAC_AAD_LEN 20
This part (and aes_cmac.c changes) shouldn't have been there, but that
was my mistake - removed.
With that, I've applied this. Will send it to davem tomorrow.
johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
To: Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org,
sergey.senozhatsky.work-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v4] mac80211: move struct aead_req off the stack
Date: Mon, 17 Oct 2016 16:17:08 +0200 [thread overview]
Message-ID: <1476713828.315.5.camel@sipsolutions.net> (raw)
In-Reply-To: <1476713133-18355-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> (sfid-20161017_160545_826866_8595CA02)
On Mon, 2016-10-17 at 15:05 +0100, Ard Biesheuvel wrote:
> From: Johannes Berg <johannes.berg-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
That really ought to have been you - I think I may have lost that by
accident. I'll change it.
> In addition, take care not to put any of our own stack allocations
> into
> scatterlists. This involves reserving some extra room when allocating
> the
> aead_request structures, and referring to those allocations in the
> scatter-
> lists (while copying the data from/to the stack before/after the
> crypto
> operation, as appropriate)
I removed the "to the stack after" language, since that doesn't
actually occur :)
> --- a/net/mac80211/aes_cmac.h
> +++ b/net/mac80211/aes_cmac.h
> @@ -11,6 +11,8 @@
>
> #include <linux/crypto.h>
>
> +#define CMAC_AAD_LEN 20
This part (and aes_cmac.c changes) shouldn't have been there, but that
was my mistake - removed.
With that, I've applied this. Will send it to davem tomorrow.
johannes
next prev parent reply other threads:[~2016-10-17 14:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 14:05 [PATCH v4] mac80211: move struct aead_req off the stack Ard Biesheuvel
2016-10-17 14:05 ` Ard Biesheuvel
2016-10-17 14:17 ` Johannes Berg [this message]
2016-10-17 14:17 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476713828.315.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ard.biesheuvel@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.