All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] DAX: enable iostat for read/write
Date: Mon, 17 Oct 2016 17:45:04 +0000	[thread overview]
Message-ID: <1476726205.20881.72.camel@hpe.com> (raw)
In-Reply-To: <20161017172957.GC25175@linux.intel.com>

On Mon, 2016-10-17 at 11:29 -0600, Ross Zwisler wrote:
> On Mon, Oct 17, 2016 at 11:18:58AM -0600, Toshi Kani wrote:
> > 
> > DAX IO path does not support iostat, but its metadata IO path does.
> > Therefore, iostat shows metadata IO statistics only, which has been
> > confusing to users.
> > 
> > Add iostat support to the DAX read/write path.
> > 
> > Note, iostat still does not support the DAX mmap path as it allows
> > user applications to access directly.
> > 
> > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> > ---
> > v2:
> > - Set a minimum of one sector (Dan Williams)
> 
> What about Dave's feedback that this code just reimplements 
> generic_start_io_acct() and generic_end_io_acct()?

My bad. There was some issue in my email box and I just realized it.
Please disregard this version... 

Thanks,
-Toshi
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2] DAX: enable iostat for read/write
Date: Mon, 17 Oct 2016 17:45:04 +0000	[thread overview]
Message-ID: <1476726205.20881.72.camel@hpe.com> (raw)
In-Reply-To: <20161017172957.GC25175@linux.intel.com>

On Mon, 2016-10-17 at 11:29 -0600, Ross Zwisler wrote:
> On Mon, Oct 17, 2016 at 11:18:58AM -0600, Toshi Kani wrote:
> > 
> > DAX IO path does not support iostat, but its metadata IO path does.
> > Therefore, iostat shows metadata IO statistics only, which has been
> > confusing to users.
> > 
> > Add iostat support to the DAX read/write path.
> > 
> > Note, iostat still does not support the DAX mmap path as it allows
> > user applications to access directly.
> > 
> > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> > ---
> > v2:
> > - Set a minimum of one sector (Dan Williams)
> 
> What about Dave's feedback that this code just reimplements 
> generic_start_io_acct() and generic_end_io_acct()?

My bad. There was some issue in my email box and I just realized it.
Please disregard this version... 

Thanks,
-Toshi

WARNING: multiple messages have this Message-ID (diff)
From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
	"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v2] DAX: enable iostat for read/write
Date: Mon, 17 Oct 2016 17:45:04 +0000	[thread overview]
Message-ID: <1476726205.20881.72.camel@hpe.com> (raw)
In-Reply-To: <20161017172957.GC25175@linux.intel.com>

On Mon, 2016-10-17 at 11:29 -0600, Ross Zwisler wrote:
> On Mon, Oct 17, 2016 at 11:18:58AM -0600, Toshi Kani wrote:
> > 
> > DAX IO path does not support iostat, but its metadata IO path does.
> > Therefore, iostat shows metadata IO statistics only, which has been
> > confusing to users.
> > 
> > Add iostat support to the DAX read/write path.
> > 
> > Note, iostat still does not support the DAX mmap path as it allows
> > user applications to access directly.
> > 
> > Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> > ---
> > v2:
> > - Set a minimum of one sector (Dan Williams)
> 
> What about Dave's feedback that this code just reimplements 
> generic_start_io_acct() and generic_end_io_acct()?

My bad. There was some issue in my email box and I just realized it.
Please disregard this version... 

Thanks,
-Toshi

  reply	other threads:[~2016-10-17 17:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 17:18 [PATCH v2] DAX: enable iostat for read/write Toshi Kani
2016-10-17 17:18 ` Toshi Kani
2016-10-17 17:18 ` Toshi Kani
2016-10-17 17:29 ` Ross Zwisler
2016-10-17 17:29   ` Ross Zwisler
2016-10-17 17:29   ` Ross Zwisler
2016-10-17 17:45   ` Kani, Toshimitsu [this message]
2016-10-17 17:45     ` Kani, Toshimitsu
2016-10-17 17:45     ` Kani, Toshimitsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476726205.20881.72.camel@hpe.com \
    --to=toshi.kani@hpe.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=ross.zwisler@linux.intel.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.