From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH V3 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers
Date: Mon, 17 Oct 2016 15:37:51 -0700 [thread overview]
Message-ID: <1476743871.2326.52.camel@intel.com> (raw)
In-Reply-To: <CAKgT0Ue7HL4CWdF2jBzLYOqXuO2=J9GeF79qfcdOWB7+cA0_3Q@mail.gmail.com>
On Mon, 2016-10-17 at 15:29 -0700, Alexander Duyck wrote:
> On Mon, Oct 17, 2016 at 2:12 PM, Sowmini Varadhan
> <sowmini.varadhan@oracle.com> wrote:
> >
> > For some Tx paths (e.g., tpacket_snd()), ixgbe_atr may be
> > passed down an sk_buff that has the network and transport
> > header in the paged data, so it needs to make sure these
> > headers are available in the headlen bytes to calculate the
> > l4_proto.
> >
> > This patch expect that network and transport headers are
> > already available in the non-paged header dat.??The assumption
> > is that the caller has set this up if l4_proto based Tx
> > steering is desired.
> >
> > Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
>
> This all looks correct to me.??I would recommend having Jeff pull it
> in to be submitted to the net queue.
>
> Reviewed-by: Alexander Duyck <alexander.h.duyck@intel.com>
Sowmini, can you re-submit this to intel-wired-lan but without the RFC in
the title?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20161017/55d2f638/attachment.asc>
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Alexander Duyck <alexander.duyck@gmail.com>,
Sowmini Varadhan <sowmini.varadhan@oracle.com>
Cc: "Duyck, Alexander H" <alexander.h.duyck@intel.com>,
Netdev <netdev@vger.kernel.org>,
intel-wired-lan <intel-wired-lan@lists.osuosl.org>
Subject: Re: [Intel-wired-lan] [PATCH V3 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers
Date: Mon, 17 Oct 2016 15:37:51 -0700 [thread overview]
Message-ID: <1476743871.2326.52.camel@intel.com> (raw)
In-Reply-To: <CAKgT0Ue7HL4CWdF2jBzLYOqXuO2=J9GeF79qfcdOWB7+cA0_3Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 995 bytes --]
On Mon, 2016-10-17 at 15:29 -0700, Alexander Duyck wrote:
> On Mon, Oct 17, 2016 at 2:12 PM, Sowmini Varadhan
> <sowmini.varadhan@oracle.com> wrote:
> >
> > For some Tx paths (e.g., tpacket_snd()), ixgbe_atr may be
> > passed down an sk_buff that has the network and transport
> > header in the paged data, so it needs to make sure these
> > headers are available in the headlen bytes to calculate the
> > l4_proto.
> >
> > This patch expect that network and transport headers are
> > already available in the non-paged header dat. The assumption
> > is that the caller has set this up if l4_proto based Tx
> > steering is desired.
> >
> > Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
>
> This all looks correct to me. I would recommend having Jeff pull it
> in to be submitted to the net queue.
>
> Reviewed-by: Alexander Duyck <alexander.h.duyck@intel.com>
Sowmini, can you re-submit this to intel-wired-lan but without the RFC in
the title?
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-10-17 22:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 21:12 [Intel-wired-lan] [PATCH v3 RFC 0/2] ixgbe: ixgbe_atr() bug fixes Sowmini Varadhan
2016-10-17 21:12 ` Sowmini Varadhan
2016-10-17 21:12 ` [Intel-wired-lan] [PATCH V3 RFC 1/2] ixgbe: ixgbe_atr() should access udp_hdr(skb) only for UDP packets Sowmini Varadhan
2016-10-17 21:12 ` Sowmini Varadhan
2016-10-17 21:12 ` [Intel-wired-lan] [PATCH V3 RFC 2/2] ixgbe: ixgbe_atr() compute l4_proto only if non-paged data has network/transport headers Sowmini Varadhan
2016-10-17 21:12 ` Sowmini Varadhan
2016-10-17 22:29 ` [Intel-wired-lan] " Alexander Duyck
2016-10-17 22:29 ` Alexander Duyck
2016-10-17 22:37 ` Jeff Kirsher [this message]
2016-10-17 22:37 ` Jeff Kirsher
2016-10-17 22:47 ` Sowmini Varadhan
2016-10-17 22:47 ` Sowmini Varadhan
2016-10-17 22:48 ` Jeff Kirsher
2016-10-17 22:48 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476743871.2326.52.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.