All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylvain Lemieux <slemieux.tyco@gmail.com>
To: Vladimir Zapolskiy <vz@mleia.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	slemieux@tycoint.com
Subject: [BUG] LPC32xx gpio driver broken by commit 762c2e46 in 4.9-rc1
Date: Tue, 18 Oct 2016 12:23:19 -0400	[thread overview]
Message-ID: <1476807799.10214.25.camel@localhost> (raw)

Vladimir, Linus, Alexandre,

the current LPC32xx GPIO driver is broken by commit 762c2e46
(gpio: of: remove of_gpiochip_and_xlate() and struct gg_data).

A call to "of_get_named_gpio" to retrieve the GPIO will
always return -EINVAL, except for the first GPIO bank.

Prior to this commit, the driver was working properly
because of the side-effect of the match function called by
"gpiochip_find" inside "of_get_named_gpiod_flags" function.

I think, the proper long-term solution is to replace the
LPC32xx GPIO driver; an initial version was previously
submitted, by Vladimir Zapolskiy, to the mailing list:
http://www.spinics.net/lists/linux-gpio/msg09746.html

Is there any short-term solution that can be done with
the existing driver to keep the LPC32xx platform working
properly in the 4.9 mainline kernel?


Regards,
Sylvain Lemieux


 




WARNING: multiple messages have this Message-ID (diff)
From: slemieux.tyco@gmail.com (Sylvain Lemieux)
To: linux-arm-kernel@lists.infradead.org
Subject: [BUG] LPC32xx gpio driver broken by commit 762c2e46 in 4.9-rc1
Date: Tue, 18 Oct 2016 12:23:19 -0400	[thread overview]
Message-ID: <1476807799.10214.25.camel@localhost> (raw)

Vladimir, Linus, Alexandre,

the current LPC32xx GPIO driver is broken by commit 762c2e46
(gpio: of: remove of_gpiochip_and_xlate() and struct gg_data).

A call to "of_get_named_gpio" to retrieve the GPIO will
always return -EINVAL, except for the first GPIO bank.

Prior to this commit, the driver was working properly
because of the side-effect of the match function called by
"gpiochip_find" inside "of_get_named_gpiod_flags" function.

I think, the proper long-term solution is to replace the
LPC32xx GPIO driver; an initial version was previously
submitted, by Vladimir Zapolskiy, to the mailing list:
http://www.spinics.net/lists/linux-gpio/msg09746.html

Is there any short-term solution that can be done with
the existing driver to keep the LPC32xx platform working
properly in the 4.9 mainline kernel?


Regards,
Sylvain Lemieux


 

             reply	other threads:[~2016-10-18 16:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-18 16:23 Sylvain Lemieux [this message]
2016-10-18 16:23 ` [BUG] LPC32xx gpio driver broken by commit 762c2e46 in 4.9-rc1 Sylvain Lemieux
2016-10-18 18:06 ` Vladimir Zapolskiy
2016-10-18 18:06   ` Vladimir Zapolskiy
2016-10-18 18:19   ` Sylvain Lemieux
2016-10-18 18:19     ` Sylvain Lemieux
2016-10-24  0:46 ` Linus Walleij
2016-10-24  0:46   ` Linus Walleij
2016-10-24  7:51   ` Masahiro Yamada
2016-10-24  7:51     ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1476807799.10214.25.camel@localhost \
    --to=slemieux.tyco@gmail.com \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=slemieux@tycoint.com \
    --cc=vz@mleia.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.