From: Johannes Berg <johannes@sipsolutions.net>
To: Luca Coelho <luca@coelho.fi>, linux-wireless@vger.kernel.org
Cc: kvalo@codeaurora.org, Aviya Erenfeld <aviya.erenfeld@intel.com>,
Luca Coelho <luciano.coelho@intel.com>
Subject: Re: [PATCH 10/10] iwlwifi: mvm: use dev_coredumpsg()
Date: Thu, 20 Oct 2016 15:31:58 +0200 [thread overview]
Message-ID: <1476970318.4929.32.camel@sipsolutions.net> (raw)
In-Reply-To: <20161019100755.23874-11-luca@coelho.fi> (sfid-20161019_171834_075034_345D0F62)
> - dev_coredumpm(mvm->trans->dev, THIS_MODULE, fw_error_dump,
> 0,
> - GFP_KERNEL, iwl_mvm_read_coredump,
> iwl_mvm_free_coredump);
> + sg_dump_data = alloc_sgtable(file_len);
> + if (sg_dump_data) {
> + sg_pcopy_from_buffer(sg_dump_data,
> + sg_nents(sg_dump_data),
> + fw_error_dump->op_mode_ptr,
> + fw_error_dump->op_mode_len, 0);
> + sg_pcopy_from_buffer(sg_dump_data,
> + sg_nents(sg_dump_data),
> + fw_error_dump->trans_ptr->data,
> + fw_error_dump->trans_ptr->len,
> + fw_error_dump->op_mode_len);
>
smatch pointed out that we check fw_error_dump->trans_ptr for NULL
earlier, and that is indeed correct afaict; I've sent you a fix
internally :)
johannes
prev parent reply other threads:[~2016-10-20 13:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 10:07 [PATCH 00/10] iwlwifi: updates intended for v4.10 2016-10-19 Luca Coelho
2016-10-19 10:07 ` [PATCH 01/10] iwlwifi: mvm: update txq metadata to current owner Luca Coelho
2016-10-19 10:07 ` [PATCH 02/10] iwlwifi: mvm: fix reserved txq freeing Luca Coelho
2016-10-19 10:07 ` [PATCH 03/10] iwlwifi: mvm: support MONITOR vif in DQA mode Luca Coelho
2016-10-19 10:07 ` [PATCH 04/10] iwlwifi: mvm: fix dqa deferred frames marking Luca Coelho
2016-10-19 10:07 ` [PATCH 05/10] iwlwifi: mvm: use firmware station PM notification for AP_LINK_PS Luca Coelho
2016-10-19 10:07 ` [PATCH 06/10] iwlwifi: pcie: give a meaningful name to interrupt request Luca Coelho
2016-10-19 10:07 ` [PATCH 07/10] iwlwifi: mvm: tell the firmware about the AID of the peer Luca Coelho
2016-10-19 10:07 ` [PATCH 08/10] iwlwifi: mvm: assign cab queue to the correct station Luca Coelho
2016-10-19 10:07 ` [PATCH 09/10] iwlwifi: mvm: operate in dqa mode Luca Coelho
2016-10-26 6:32 ` Kalle Valo
2016-10-26 6:44 ` Coelho, Luciano
2016-10-26 7:14 ` Kalle Valo
2016-10-26 7:23 ` Valo, Kalle
2016-10-26 8:09 ` [PATCH v2] iwlwifi: mvm: enable dynamic queue allocation mode Luca Coelho
2016-10-19 10:07 ` [PATCH 10/10] iwlwifi: mvm: use dev_coredumpsg() Luca Coelho
2016-10-20 13:31 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476970318.4929.32.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=aviya.erenfeld@intel.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.