From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: "Coelho, Luciano" <luciano.coelho@intel.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Kaufman, Liad" <liad.kaufman@intel.com>
Subject: Re: [PATCH 09/10] iwlwifi: mvm: operate in dqa mode
Date: Wed, 26 Oct 2016 07:23:34 +0000 [thread overview]
Message-ID: <87mvhr60ay.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <87r37360qq.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Wed, 26 Oct 2016 10:14:05 +0300")
Kalle Valo <kvalo@codeaurora.org> writes:
>> Since we've been working on this for so long and already use the term
>> DQA broadly, we thought it wouldn't be necessary to explain more when
>> we are finally enabling it by default. But of course I can change that
>> if you prefer.
>
> I guessed I could find more information from the history and I know this
> is obvious to your team, but it's not obvious to everyone. The commit
> log should always answer the questions "Why?" and this isn't answering
> that. For example, I need this information when sending pull requests to
> Dave and I'm sure lots of other people find it useful as well,
> especially when enabling a new feature.
>
> So I'm not asking for a long essay, something like this would be
> adequate:
>
> "Run DQA flows by default, as long as the FW supports it. It's currently
> supported on 1234, 3456 and 7654, maybe more in the future. DQA improves
> latency when X is used or throughput when Y is disabled. On the downside
> it sometimes slows down throughput when using Z but that's still
> accetable as it's so rarely used."
Oh, I forgot that the acronym should be also spelled out in the commit
log.
--=20
Kalle Valo=
next prev parent reply other threads:[~2016-10-26 7:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 10:07 [PATCH 00/10] iwlwifi: updates intended for v4.10 2016-10-19 Luca Coelho
2016-10-19 10:07 ` [PATCH 01/10] iwlwifi: mvm: update txq metadata to current owner Luca Coelho
2016-10-19 10:07 ` [PATCH 02/10] iwlwifi: mvm: fix reserved txq freeing Luca Coelho
2016-10-19 10:07 ` [PATCH 03/10] iwlwifi: mvm: support MONITOR vif in DQA mode Luca Coelho
2016-10-19 10:07 ` [PATCH 04/10] iwlwifi: mvm: fix dqa deferred frames marking Luca Coelho
2016-10-19 10:07 ` [PATCH 05/10] iwlwifi: mvm: use firmware station PM notification for AP_LINK_PS Luca Coelho
2016-10-19 10:07 ` [PATCH 06/10] iwlwifi: pcie: give a meaningful name to interrupt request Luca Coelho
2016-10-19 10:07 ` [PATCH 07/10] iwlwifi: mvm: tell the firmware about the AID of the peer Luca Coelho
2016-10-19 10:07 ` [PATCH 08/10] iwlwifi: mvm: assign cab queue to the correct station Luca Coelho
2016-10-19 10:07 ` [PATCH 09/10] iwlwifi: mvm: operate in dqa mode Luca Coelho
2016-10-26 6:32 ` Kalle Valo
2016-10-26 6:44 ` Coelho, Luciano
2016-10-26 7:14 ` Kalle Valo
2016-10-26 7:23 ` Valo, Kalle [this message]
2016-10-26 8:09 ` [PATCH v2] iwlwifi: mvm: enable dynamic queue allocation mode Luca Coelho
2016-10-19 10:07 ` [PATCH 10/10] iwlwifi: mvm: use dev_coredumpsg() Luca Coelho
2016-10-20 13:31 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvhr60ay.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=liad.kaufman@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.