From: Dario Faggioli <dario.faggioli@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Juergen Gross <jgross@suse.com>, Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH v2] libxl: initialise nr_dom_vcpus to fix 4a6070ea9
Date: Mon, 24 Oct 2016 12:22:28 +0200 [thread overview]
Message-ID: <1477304548.27407.1.camel@citrix.com> (raw)
In-Reply-To: <1477303875-4017-1-git-send-email-wei.liu2@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 724 bytes --]
On Mon, 2016-10-24 at 11:11 +0100, Wei Liu wrote:
> Clang complains nr_dom_vcpus may be used uninitialised after
> 4a6070ea9.
>
> The real issue is vinfo can be NULL and nr_dom_vcpus remains
> uninitialised if previous call fails.
>
> Initialise nr_dom_vcpus to 0 at the beginning of the loop to fix the
> issue.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-24 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 10:11 [PATCH v2] libxl: initialise nr_dom_vcpus to fix 4a6070ea9 Wei Liu
2016-10-24 10:22 ` Dario Faggioli [this message]
2016-10-24 10:36 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477304548.27407.1.camel@citrix.com \
--to=dario.faggioli@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.