All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart.VanAssche@sandisk.com (Bart Van Assche)
Subject: [PATCH v3 4/6] nvme-rdma: use rdma connection reject helper functions
Date: Tue, 25 Oct 2016 18:25:56 +0000	[thread overview]
Message-ID: <1477419953.2385.3.camel@sandisk.com> (raw)
In-Reply-To: <014d01d22eec$832e60e0$898b22a0$@opengridcomputing.com>

On Tue, 2016-10-25@13:20 -0500, Steve Wise wrote:
> > 
> > On 10/24/2016 12:09 PM, Steve Wise wrote:
> > > 
> > > +	rej_msg = rdma_reject_msg(cm_id, status);
> > > +	rej_data = (struct nvme_rdma_cm_rej *)
> > > +		???rdma_consumer_reject_data(cm_id, ev,
> > > &rej_data_len);
> > 
> > Please reorder the patches in this patch series such that it
> > doesn't
> > break a bisect. rdma_consumer_reject_data() should be introduced
> > before
> > it is used.
> 
> rdma_consumer_reject_data() is introduced in patch 3.

Hello Steve,

Thanks for the feedback. Apparently my e-mail client displayed the
patches in the wrong order ...

Bart.

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: "swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org"
	<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
	"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org"
	<sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "hch-jcswGhMUV9g@public.gmane.org"
	<hch-jcswGhMUV9g@public.gmane.org>,
	"santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org"
	<santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	"axboe-b10kYP2dOMg@public.gmane.org"
	<axboe-b10kYP2dOMg@public.gmane.org>,
	"sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org"
	<sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Subject: Re: [PATCH v3 4/6] nvme-rdma: use rdma connection reject helper functions
Date: Tue, 25 Oct 2016 18:25:56 +0000	[thread overview]
Message-ID: <1477419953.2385.3.camel@sandisk.com> (raw)
In-Reply-To: <014d01d22eec$832e60e0$898b22a0$@opengridcomputing.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 793 bytes --]

On Tue, 2016-10-25 at 13:20 -0500, Steve Wise wrote:
> > 
> > On 10/24/2016 12:09 PM, Steve Wise wrote:
> > > 
> > > +	rej_msg = rdma_reject_msg(cm_id, status);
> > > +	rej_data = (struct nvme_rdma_cm_rej *)
> > > +		   rdma_consumer_reject_data(cm_id, ev,
> > > &rej_data_len);
> > 
> > Please reorder the patches in this patch series such that it
> > doesn't
> > break a bisect. rdma_consumer_reject_data() should be introduced
> > before
> > it is used.
> 
> rdma_consumer_reject_data() is introduced in patch 3.

Hello Steve,

Thanks for the feedback. Apparently my e-mail client displayed the
patches in the wrong order ...

Bart.N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±­ÙšŠ{ayº\x1dʇڙë,j\a­¢f£¢·hš‹»öì\x17/oSc¾™Ú³9˜uÀ¦æå‰È&jw¨®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿïêäz¹Þ–Šàþf£¢·hšˆ§~ˆmš

  reply	other threads:[~2016-10-25 18:25 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-24 19:07 [PATCH v3 0/6] connect reject event helpers Steve Wise
2016-10-24 19:07 ` Steve Wise
2016-10-24 18:59 ` [PATCH v3 3/6] rdma_cm: add rdma_consumer_reject_data helper function Steve Wise
2016-10-24 18:59   ` Steve Wise
2016-10-25 16:36   ` Sagi Grimberg
2016-10-25 16:36     ` Sagi Grimberg
2016-10-25 17:01   ` Christoph Hellwig
2016-10-25 17:01     ` Christoph Hellwig
2016-10-24 18:59 ` [PATCH v3 2/6] rdma_cm: add rdma_is_consumer_reject() " Steve Wise
2016-10-24 18:59   ` Steve Wise
2016-10-25 16:36   ` Sagi Grimberg
2016-10-25 16:36     ` Sagi Grimberg
2016-10-25 17:00   ` Christoph Hellwig
2016-10-25 17:00     ` Christoph Hellwig
2016-10-24 18:59 ` [PATCH v3 1/6] rdma_cm: add rdma_reject_msg() " Steve Wise
2016-10-24 18:59   ` Steve Wise
2016-10-25 16:37   ` Sagi Grimberg
2016-10-25 16:37     ` Sagi Grimberg
2016-10-25 17:00   ` Christoph Hellwig
2016-10-25 17:00     ` Christoph Hellwig
2016-10-25 17:58   ` Bart Van Assche
2016-10-25 17:58     ` Bart Van Assche
2016-10-25 18:18     ` Steve Wise
2016-10-25 18:18       ` Steve Wise
2016-10-24 19:07 ` [PATCH v3 4/6] nvme-rdma: use rdma connection reject helper functions Steve Wise
2016-10-24 19:07   ` Steve Wise
2016-10-25 16:36   ` Sagi Grimberg
2016-10-25 16:36     ` Sagi Grimberg
2016-10-25 16:58     ` Steve Wise
2016-10-25 16:58       ` Steve Wise
2016-10-25 17:02     ` Christoph Hellwig
2016-10-25 17:02       ` Christoph Hellwig
2016-10-25 17:04       ` Sagi Grimberg
2016-10-25 17:04         ` Sagi Grimberg
2016-10-25 17:01   ` Christoph Hellwig
2016-10-25 17:01     ` Christoph Hellwig
2016-10-25 18:05   ` Bart Van Assche
2016-10-25 18:05     ` Bart Van Assche
2016-10-25 18:20     ` Steve Wise
2016-10-25 18:20       ` Steve Wise
2016-10-25 18:25       ` Bart Van Assche [this message]
2016-10-25 18:25         ` Bart Van Assche
2016-10-24 19:07 ` [PATCH v3 5/6] ib_iser: log the connection reject message Steve Wise
2016-10-24 19:07   ` Steve Wise
2016-10-25 16:34   ` Sagi Grimberg
2016-10-25 16:34     ` Sagi Grimberg
2016-10-24 19:07 ` [PATCH v3 6/6] rds_rdma: " Steve Wise
2016-10-24 19:07   ` Steve Wise
2016-10-25 15:51   ` Santosh Shilimkar
2016-10-25 15:51     ` Santosh Shilimkar
2016-10-25 16:04     ` Steve Wise
2016-10-25 16:04       ` Steve Wise
2016-10-25 16:11       ` Santosh Shilimkar
2016-10-25 16:11         ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477419953.2385.3.camel@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.