All of lore.kernel.org
 help / color / mirror / Atom feed
From: Colin Vidal <colin@cvidal.org>
To: Elena Reshetova <elena.reshetova@intel.com>,
	Hans Liljestrand <ishkamiel@gmail.com>
Cc: kernel-hardening@lists.openwall.com
Subject: [kernel-hardening] fix typo __atomic_op_fence
Date: Tue, 25 Oct 2016 21:35:49 +0200	[thread overview]
Message-ID: <1477424149.2263.52.camel@cvidal.org> (raw)

Hi Hans,

can you apply this little fix on the
commit b5cafefa6ec2dd549174edc8fbd678c06fcb0472 you have just pushed on
Elena's hardened_atomic_on_next ?

Otherwise, any build that use atomic_xchg_relaxed and
atomic_cmpxchg_relaxed is broken.

Thanks :)

Colin

diff --git a/include/linux/atomic.h b/include/linux/atomic.h
index 4e9972d..ffd2e33 100644
--- a/include/linux/atomic.h
+++ b/include/linux/atomic.h
@@ -427,7 +427,7 @@
 
 #ifndef atomic_xchg_wrap
 #define  atomic_xchg_wrap(...)                         \
-       _atomic_op_fence(atomic_xchg_wrap, __VA_ARGS__)
+       __atomic_op_fence(atomic_xchg_wrap, __VA_ARGS__)
 #endif
 #endif /* atomic_xchg_relaxed */
 
@@ -456,7 +456,7 @@
 
 #ifndef atomic_cmpxchg_wrap
 #define  atomic_cmpxchg_wrap(...)                              \
-       _atomic_op_fence(atomic_cmpxchg_wrap, __VA_ARGS__)
+       __atomic_op_fence(atomic_cmpxchg_wrap, __VA_ARGS__)
 #endif
 #endif /* atomic_cmpxchg_relaxed */

             reply	other threads:[~2016-10-25 19:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 19:35 Colin Vidal [this message]
2016-10-26  7:01 ` [kernel-hardening] RE: fix typo __atomic_op_fence Reshetova, Elena

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477424149.2263.52.camel@cvidal.org \
    --to=colin@cvidal.org \
    --cc=elena.reshetova@intel.com \
    --cc=ishkamiel@gmail.com \
    --cc=kernel-hardening@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.