All of lore.kernel.org
 help / color / mirror / Atom feed
* [kernel-hardening] fix typo __atomic_op_fence
@ 2016-10-25 19:35 Colin Vidal
  2016-10-26  7:01 ` [kernel-hardening] " Reshetova, Elena
  0 siblings, 1 reply; 2+ messages in thread
From: Colin Vidal @ 2016-10-25 19:35 UTC (permalink / raw)
  To: Elena Reshetova, Hans Liljestrand; +Cc: kernel-hardening

Hi Hans,

can you apply this little fix on the
commit b5cafefa6ec2dd549174edc8fbd678c06fcb0472 you have just pushed on
Elena's hardened_atomic_on_next ?

Otherwise, any build that use atomic_xchg_relaxed and
atomic_cmpxchg_relaxed is broken.

Thanks :)

Colin

diff --git a/include/linux/atomic.h b/include/linux/atomic.h
index 4e9972d..ffd2e33 100644
--- a/include/linux/atomic.h
+++ b/include/linux/atomic.h
@@ -427,7 +427,7 @@
 
 #ifndef atomic_xchg_wrap
 #define  atomic_xchg_wrap(...)                         \
-       _atomic_op_fence(atomic_xchg_wrap, __VA_ARGS__)
+       __atomic_op_fence(atomic_xchg_wrap, __VA_ARGS__)
 #endif
 #endif /* atomic_xchg_relaxed */
 
@@ -456,7 +456,7 @@
 
 #ifndef atomic_cmpxchg_wrap
 #define  atomic_cmpxchg_wrap(...)                              \
-       _atomic_op_fence(atomic_cmpxchg_wrap, __VA_ARGS__)
+       __atomic_op_fence(atomic_cmpxchg_wrap, __VA_ARGS__)
 #endif
 #endif /* atomic_cmpxchg_relaxed */

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [kernel-hardening] RE: fix typo __atomic_op_fence
  2016-10-25 19:35 [kernel-hardening] fix typo __atomic_op_fence Colin Vidal
@ 2016-10-26  7:01 ` Reshetova, Elena
  0 siblings, 0 replies; 2+ messages in thread
From: Reshetova, Elena @ 2016-10-26  7:01 UTC (permalink / raw)
  To: Colin Vidal, Hans Liljestrand; +Cc: kernel-hardening@lists.openwall.com

Hi Colin, 

Sorry for the trouble. I have just applied the fix and pushed the update to the repo.  

Best Regards,
Elena.

-----Original Message-----
From: Colin Vidal [mailto:colin@cvidal.org] 
Sent: Tuesday, October 25, 2016 10:36 PM
To: Reshetova, Elena <elena.reshetova@intel.com>; Hans Liljestrand <ishkamiel@gmail.com>
Cc: kernel-hardening@lists.openwall.com
Subject: fix typo __atomic_op_fence

Hi Hans,

can you apply this little fix on the
commit b5cafefa6ec2dd549174edc8fbd678c06fcb0472 you have just pushed on Elena's hardened_atomic_on_next ?

Otherwise, any build that use atomic_xchg_relaxed and atomic_cmpxchg_relaxed is broken.

Thanks :)

Colin

diff --git a/include/linux/atomic.h b/include/linux/atomic.h index 4e9972d..ffd2e33 100644
--- a/include/linux/atomic.h
+++ b/include/linux/atomic.h
@@ -427,7 +427,7 @@
 
 #ifndef atomic_xchg_wrap
 #define  atomic_xchg_wrap(...)                         \
-       _atomic_op_fence(atomic_xchg_wrap, __VA_ARGS__)
+       __atomic_op_fence(atomic_xchg_wrap, __VA_ARGS__)
 #endif
 #endif /* atomic_xchg_relaxed */
 
@@ -456,7 +456,7 @@
 
 #ifndef atomic_cmpxchg_wrap
 #define  atomic_cmpxchg_wrap(...)                              \
-       _atomic_op_fence(atomic_cmpxchg_wrap, __VA_ARGS__)
+       __atomic_op_fence(atomic_cmpxchg_wrap, __VA_ARGS__)
 #endif
 #endif /* atomic_cmpxchg_relaxed */

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-26  7:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-25 19:35 [kernel-hardening] fix typo __atomic_op_fence Colin Vidal
2016-10-26  7:01 ` [kernel-hardening] " Reshetova, Elena

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.