From: Gerd Hoffmann <kraxel@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] gtk: fix compilation warning with gtk 3.22.2
Date: Thu, 27 Oct 2016 13:50:44 +0200 [thread overview]
Message-ID: <1477569044.9075.13.camel@redhat.com> (raw)
In-Reply-To: <w51vawf9l7l.fsf@maestria.local.igalia.com>
On Mi, 2016-10-26 at 17:35 +0200, Alberto Garcia wrote:
> On Wed 26 Oct 2016 05:21:08 PM CEST, Alberto Garcia wrote:
> > +#else
> > + {
> > + screen_width = gdk_screen_get_width(screen);
> > + screen_height = gdk_screen_get_height(screen);
> > + }
> > +#endif
>
> I forgot to remove these braces, they are actually not necessary, so
> whoever applies the patch can remove them if they want. I don't mind if
> we keep them for clarity, though, I'm fine either way.
Taking patch as-is, I find it more readable with the braces.
thanks,
Gerd
prev parent reply other threads:[~2016-10-27 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 15:21 [Qemu-devel] [PATCH] gtk: fix compilation warning with gtk 3.22.2 Alberto Garcia
2016-10-26 15:35 ` Alberto Garcia
2016-10-27 11:50 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477569044.9075.13.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=berto@igalia.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.