All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] ui/gtk: Fix non-working DELETE key
Date: Thu, 27 Oct 2016 15:45:51 +0200	[thread overview]
Message-ID: <1477575951.9075.14.camel@redhat.com> (raw)
In-Reply-To: <1477570647-7100-1-git-send-email-thuth@redhat.com>

On Do, 2016-10-27 at 14:17 +0200, Thomas Huth wrote:
> GTK generates key events for the delete key with key->string[0] = 0x7f
> ... but this does not work right with the readline_handle_byte()
> function in util/readline.c, since this treats the keycode 127 as
> backspace. So let's add a special case for the GTK delete key to make
> this key behave right in the monitor interface of the GTK ui.

added to ui queue.

thanks,
  Gerd



WARNING: multiple messages have this Message-ID (diff)
From: Gerd Hoffmann <kraxel@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ui/gtk: Fix non-working DELETE key
Date: Thu, 27 Oct 2016 15:45:51 +0200	[thread overview]
Message-ID: <1477575951.9075.14.camel@redhat.com> (raw)
In-Reply-To: <1477570647-7100-1-git-send-email-thuth@redhat.com>

On Do, 2016-10-27 at 14:17 +0200, Thomas Huth wrote:
> GTK generates key events for the delete key with key->string[0] = 0x7f
> ... but this does not work right with the readline_handle_byte()
> function in util/readline.c, since this treats the keycode 127 as
> backspace. So let's add a special case for the GTK delete key to make
> this key behave right in the monitor interface of the GTK ui.

added to ui queue.

thanks,
  Gerd

  reply	other threads:[~2016-10-27 13:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-27 12:17 [Qemu-trivial] [PATCH] ui/gtk: Fix non-working DELETE key Thomas Huth
2016-10-27 12:17 ` [Qemu-devel] " Thomas Huth
2016-10-27 13:45 ` Gerd Hoffmann [this message]
2016-10-27 13:45   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477575951.9075.14.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.