From: Joe Perches <joe@perches.com>
To: Sven Eckelmann <sven@narfation.org>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
Antonio Quartulli <a@unstable.cc>,
davem@davemloft.net
Subject: Re: [B.A.T.M.A.N.] [PATCH 17/17] batman-adv: Avoid precedence issues in macros
Date: Fri, 28 Oct 2016 18:56:24 -0700 [thread overview]
Message-ID: <1477706184.23018.3.camel@perches.com> (raw)
In-Reply-To: <4261316.fWqmHPy2zE@sven-edge>
On Fri, 2016-10-28 at 23:27 +0200, Sven Eckelmann wrote:
> On Freitag, 28. Oktober 2016 14:13:06 CEST Joe Perches wrote:
> > On Thu, 2016-10-27 at 21:01 +0200, Simon Wunderlich wrote:
> > > From: Sven Eckelmann <sven@narfation.org>
> > >
> > > It must be avoided that arguments to a macro are evaluated ungrouped (which
> > > enforces normal operator precendence). Otherwise the result of the macro
> > > is not well defined.
> >
> > Curiosity:
> >
> > in net/batman-adv/tp_meter.c
>
> [...]
> > orig_node = batadv_orig_hash_find(bat_priv, tp_vars->other_end);
> > if (unlikely(!orig_node)) {
> > err = BATADV_TP_REASON_DST_UNREACHABLE;
> > tp_vars->reason = err;
> > goto out;
> > }
> >
> > primary_if = batadv_primary_if_get_selected(bat_priv);
> > if (unlikely(!primary_if)) {
> > err = BATADV_TP_REASON_DST_UNREACHABLE;
> > goto out;
> > }
> >
> > err is not used in the out block
> >
> > Is the last if block supposed to set tp_vars->reason to err?
>
> This seems to be unrelated to this patch.
Kinda. I was looking at how the one instance of
batadv_tp_is_error was used and it's in this file.
> But yes, looks to me like it is missing. Do you want to propose a patch or
> should I do?
As you are working on this file, perhaps you should.
cheers, Joe
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Sven Eckelmann <sven@narfation.org>
Cc: Simon Wunderlich <sw@simonwunderlich.de>,
davem@davemloft.net, netdev@vger.kernel.org,
b.a.t.m.a.n@lists.open-mesh.org,
Antonio Quartulli <a@unstable.cc>
Subject: Re: [PATCH 17/17] batman-adv: Avoid precedence issues in macros
Date: Fri, 28 Oct 2016 18:56:24 -0700 [thread overview]
Message-ID: <1477706184.23018.3.camel@perches.com> (raw)
In-Reply-To: <4261316.fWqmHPy2zE@sven-edge>
On Fri, 2016-10-28 at 23:27 +0200, Sven Eckelmann wrote:
> On Freitag, 28. Oktober 2016 14:13:06 CEST Joe Perches wrote:
> > On Thu, 2016-10-27 at 21:01 +0200, Simon Wunderlich wrote:
> > > From: Sven Eckelmann <sven@narfation.org>
> > >
> > > It must be avoided that arguments to a macro are evaluated ungrouped (which
> > > enforces normal operator precendence). Otherwise the result of the macro
> > > is not well defined.
> >
> > Curiosity:
> >
> > in net/batman-adv/tp_meter.c
>
> [...]
> > orig_node = batadv_orig_hash_find(bat_priv, tp_vars->other_end);
> > if (unlikely(!orig_node)) {
> > err = BATADV_TP_REASON_DST_UNREACHABLE;
> > tp_vars->reason = err;
> > goto out;
> > }
> >
> > primary_if = batadv_primary_if_get_selected(bat_priv);
> > if (unlikely(!primary_if)) {
> > err = BATADV_TP_REASON_DST_UNREACHABLE;
> > goto out;
> > }
> >
> > err is not used in the out block
> >
> > Is the last if block supposed to set tp_vars->reason to err?
>
> This seems to be unrelated to this patch.
Kinda. I was looking at how the one instance of
batadv_tp_is_error was used and it's in this file.
> But yes, looks to me like it is missing. Do you want to propose a patch or
> should I do?
As you are working on this file, perhaps you should.
cheers, Joe
next prev parent reply other threads:[~2016-10-29 1:56 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 19:01 [B.A.T.M.A.N.] [PATCH 00/17] pull request for net-next: batman-adv 2016-10-27 Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 01/17] batman-adv: Start new development cycle Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 02/17] batman-adv: Add B.A.T.M.A.N. V sysfs files to README Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 03/17] batman-adv: Add network_coding and mcast " Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-29 10:33 ` [B.A.T.M.A.N.] " Jiri Pirko
2016-10-29 10:33 ` Jiri Pirko
2016-10-29 10:37 ` [B.A.T.M.A.N.] " Sven Eckelmann
2016-10-29 10:37 ` Sven Eckelmann
2016-10-29 10:56 ` [B.A.T.M.A.N.] " Jiri Pirko
2016-10-29 10:56 ` Jiri Pirko
2016-10-29 11:46 ` [B.A.T.M.A.N.] " Sven Eckelmann
2016-10-29 11:46 ` Sven Eckelmann
2016-10-29 13:51 ` [B.A.T.M.A.N.] " Jiri Pirko
2016-10-29 13:51 ` Jiri Pirko
2018-03-27 15:43 ` [B.A.T.M.A.N.] " Linus Lüssing
2018-05-07 6:34 ` Sven Eckelmann
2018-05-07 6:34 ` Sven Eckelmann
2018-05-20 4:37 ` [B.A.T.M.A.N.] " Sven Eckelmann
2018-05-20 4:37 ` Sven Eckelmann
2018-05-20 6:19 ` [B.A.T.M.A.N.] " Jiri Pirko
2018-05-20 6:19 ` Jiri Pirko
2018-08-04 9:24 ` [B.A.T.M.A.N.] " Antonio Quartulli
2018-08-04 9:36 ` Jiri Pirko
2018-08-04 9:36 ` Jiri Pirko
2018-08-04 11:19 ` [B.A.T.M.A.N.] " Antonio Quartulli
2018-08-04 11:52 ` Jiri Pirko
2018-08-04 11:52 ` Jiri Pirko
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 04/17] batman-adv: Add dat, mcast, nc and neighbor debugfs " Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 05/17] batman-adv: Document new nc, mcast and tpmeter log levels Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 06/17] batman-adv: Remove unused function batadv_hash_delete Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 07/17] batman-adv: Move batadv_sum_counter to soft-interface.c Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 08/17] batman-adv: Remove unused batadv_icmp_user_cmd_type Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 09/17] batman-adv: fix batadv_forw_packet kerneldoc for list attribute Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 10/17] batman-adv: remove unsed argument from batadv_dbg_arp() function Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 11/17] batman-adv: Allow selecting BATMAN V if CFG80211 is not built Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 12/17] batman-adv: Less function calls in batadv_is_ap_isolated() after error detection Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 13/17] batman-adv: Remove needless init of variables on stack Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 14/17] batman-adv: Use proper name for fragments list head Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 15/17] batman-adv: Use proper name for gateway " Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 16/17] batman-adv: Use octal permissions instead of macros Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-27 19:01 ` [B.A.T.M.A.N.] [PATCH 17/17] batman-adv: Avoid precedence issues in macros Simon Wunderlich
2016-10-27 19:01 ` Simon Wunderlich
2016-10-28 21:13 ` [B.A.T.M.A.N.] " Joe Perches
2016-10-28 21:13 ` Joe Perches
2016-10-28 21:27 ` [B.A.T.M.A.N.] " Sven Eckelmann
2016-10-28 21:27 ` Sven Eckelmann
2016-10-29 1:56 ` Joe Perches [this message]
2016-10-29 1:56 ` Joe Perches
2016-10-29 6:52 ` [B.A.T.M.A.N.] " Sven Eckelmann
2016-10-29 6:52 ` Sven Eckelmann
2016-10-29 20:28 ` [B.A.T.M.A.N.] [PATCH 00/17] pull request for net-next: batman-adv 2016-10-27 David Miller
2016-10-29 20:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477706184.23018.3.camel@perches.com \
--to=joe@perches.com \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.