Re: [PATCH 1/3] scsi_dh_rdac: switch to scsi_execute_req_flags()

["Ewan D. Milne" <emilne@redhat.com>]

On Tue, 2016-11-01 at 22:49 +0100, Hannes Reinecke wrote:
...
>  static int get_lun_info(struct scsi_device *sdev, struct rdac_dh_data *h,
>  			char *array_name, u8 *array_id)
>  {
> -	int err, i;
> -	struct c8_inquiry *inqp;
> +	int err = SCSI_DH_IO, i;
> +	struct c8_inquiry *inqp = &h->inq.c8;
>  
> -	err = submit_inquiry(sdev, 0xC8, sizeof(struct c8_inquiry), h);
> -	if (err == SCSI_DH_OK) {
> -		inqp = &h->inq.c8;
> +	if (!scsi_get_vpd_page(sdev, 0xC8, (unsigned char *)inqp,
> +			       sizeof(struct c8_inquiry))) {
>  		if (inqp->page_code != 0xc8)
>  			return SCSI_DH_NOSYS;
>  		if (inqp->page_id[0] != 'e' || inqp->page_id[1] != 'd' ||
> @@ -453,20 +382,20 @@ static int get_lun_info(struct scsi_device *sdev, struct rdac_dh_data *h,
>  		*(array_name+ARRAY_LABEL_LEN-1) = '\0';
>  		memset(array_id, 0, UNIQUE_ID_LEN);
>  		memcpy(array_id, inqp->array_unique_id, inqp->array_uniq_id_len);
> +		err = SCSI_DH_OK;
>  	}
>  	return err;
>  }
>  

In this and other places the patch changes the code from submitting the
INQUIRY/EVPD command for the page it wants, to calling scsi_get_vpd_page().
scsi_get_vpd_page() will return -EINVAL if the device did not report in
VPD page 0 that the requested page is in the list of supported pages.
Did you actually verify that the RDAC returns all of these VPD pages in
its VPD page 0 list?

I mean, I know it's supposed to, but these are old devices.

-Ewan