Re: [PATCH 1/3] scsi_dh_rdac: switch to scsi_execute_req_flags()

[Christoph Hellwig <hch@lst.de>]

On Tue, Nov 01, 2016 at 10:49:36PM +0100, Hannes Reinecke wrote:
> Switch to scsi_execute_req_flags() instead of
> using the block interface directly. This will set
> REQ_QUIET and REQ_PREEMPT, but this is okay as
> we're evaluating the errors anyway and should be
> able to send the command even if the device is
> quiesced.

Actually most users are switched to scsi_get_vpd_page if I read the patch
right, which is even better.  And it seems like the remaining user of
scsi_execute_req_flags could be switch to use scsi_mode_select() as well,
but maybe we should leave that out for now.

> +	if (scsi_execute_req_flags(sdev, cdb, DMA_TO_DEVICE,
> +				   &h->ctlr->mode_select, data_size, &sshdr,
> +				   RDAC_TIMEOUT * HZ,
> +				   RDAC_RETRIES, NULL, REQ_FAILFAST_MASK)) {

Pleae use the individual failfast flags - REQ_FAILFAST_MASK is just
for block layer use.