From: Joe Perches <joe@perches.com>
To: James Simmons <jsimmons@infradead.org>,
Nicholas Hanley <nicholasjhanley@gmail.com>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [lustre-devel] [PATCH] staging: lustre: o2iblnd: replace space indentation with tabs
Date: Sun, 06 Nov 2016 18:47:41 -0800 [thread overview]
Message-ID: <1478486861.13362.2.camel@perches.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1611070202090.21293@casper.infradead.org>
On Mon, 2016-11-07 at 02:02 +0000, James Simmons wrote:
> > This patch fixes all CODE_INDENT checkpatch errors in o2iblnd.
> Reviewed-by: James Simmons <jsimmons@infradead.org>
[]
> > diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
[]
> > @@ -1637,7 +1637,7 @@ int kiblnd_fmr_pool_map(struct kib_fmr_poolset *fps, struct kib_tx *tx,
> > {
> > __u64 *pages = tx->tx_pages;
> > bool is_rx = (rd != tx->tx_rd);
> > - bool tx_pages_mapped = 0;
> > + bool tx_pages_mapped = 0;
It's generally better to use bool assignments to true/false not 1/0.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: James Simmons <jsimmons@infradead.org>,
Nicholas Hanley <nicholasjhanley@gmail.com>
Cc: oleg.drokin@intel.com, andreas.dilger@intel.com,
gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: o2iblnd: replace space indentation with tabs
Date: Sun, 06 Nov 2016 18:47:41 -0800 [thread overview]
Message-ID: <1478486861.13362.2.camel@perches.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1611070202090.21293@casper.infradead.org>
On Mon, 2016-11-07 at 02:02 +0000, James Simmons wrote:
> > This patch fixes all CODE_INDENT checkpatch errors in o2iblnd.
> Reviewed-by: James Simmons <jsimmons@infradead.org>
[]
> > diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c
[]
> > @@ -1637,7 +1637,7 @@ int kiblnd_fmr_pool_map(struct kib_fmr_poolset *fps, struct kib_tx *tx,
> > {
> > __u64 *pages = tx->tx_pages;
> > bool is_rx = (rd != tx->tx_rd);
> > - bool tx_pages_mapped = 0;
> > + bool tx_pages_mapped = 0;
It's generally better to use bool assignments to true/false not 1/0.
next prev parent reply other threads:[~2016-11-07 2:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-05 0:02 [PATCH] staging: lustre: o2iblnd: replace space indentation with tabs Nicholas Hanley
2016-11-05 0:03 ` [lustre-devel] " Nicholas Hanley
2016-11-07 2:02 ` James Simmons
2016-11-07 2:02 ` James Simmons
2016-11-07 2:47 ` Joe Perches [this message]
2016-11-07 2:47 ` Joe Perches
2016-11-07 3:55 ` [lustre-devel] " James Simmons
2016-11-07 3:55 ` James Simmons
2016-11-07 6:43 ` [lustre-devel] " Greg KH
2016-11-07 6:43 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478486861.13362.2.camel@perches.com \
--to=joe@perches.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=nicholasjhanley@gmail.com \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.