From: Oliver Neukum <oneukum@suse.com>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] USB: cdc-acm: fix TIOCMIWAIT
Date: Tue, 08 Nov 2016 15:04:35 +0100 [thread overview]
Message-ID: <1478613875.2168.1.camel@suse.com> (raw)
In-Reply-To: <1478607057-21181-1-git-send-email-johan@kernel.org>
On Tue, 2016-11-08 at 13:10 +0100, Johan Hovold wrote:
> The TIOCMIWAIT implementation would return -EINVAL if any of the three
> supported signals were included in the mask.
>
> Instead of returning an error in case TIOCM_CTS is included, simply
> drop the mask check completely, which is in accordance with how other
> drivers implement this ioctl.
>
> Fixes: 5a6a62bdb925 ("cdc-acm: add TIOCMIWAIT")
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Oliver Neukum <oneukum@suse.com>
Regards
Oliver
prev parent reply other threads:[~2016-11-08 14:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 12:10 [PATCH] USB: cdc-acm: fix TIOCMIWAIT Johan Hovold
2016-11-08 14:04 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478613875.2168.1.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.