All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey.Brodkin@synopsys.com (Alexey Brodkin)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH v2] ARC: [plat-eznps] set default baud for early console
Date: Tue, 8 Nov 2016 14:15:39 +0000	[thread overview]
Message-ID: <1478614492.5131.57.camel@synopsys.com> (raw)
In-Reply-To: <DB6PR0501MB25184677C0582EB877C5E99DAAA60@DB6PR0501MB2518.eurprd05.prod.outlook.com>

Hi Noam,

On Tue, 2016-11-08@14:13 +0000, Noam Camus wrote:
> > 
> > From: Alexey Brodkin [mailto:Alexey.Brodkin at synopsys.com]?
> > Sent: Tuesday, November 8, 2016 4:08 PM
> 
> > 
> > Could you please provide a changelog (v1 -> v2) so reviewers may have a hint about changes you made if any.
> ... Just fix some typos in log
> This line somehow was removed from patch while sending (It is at patch head followed by line with ---)
> Basically in V1 I wrote that default value is good while I meant is NOT good (fixed in V2).

Thanks for explanation.
IMHO it worth adding that kind of changelog on each next iteration so
please keep it in mind next time :)

-Alexey

WARNING: multiple messages have this Message-ID (diff)
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "noamca@mellanox.com" <noamca@mellanox.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Vineet.Gupta1@synopsys.com" <Vineet.Gupta1@synopsys.com>,
	"linux-snps-arc@lists.infradead.org" 
	<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH v2] ARC: [plat-eznps] set default baud for early console
Date: Tue, 8 Nov 2016 14:15:39 +0000	[thread overview]
Message-ID: <1478614492.5131.57.camel@synopsys.com> (raw)
In-Reply-To: <DB6PR0501MB25184677C0582EB877C5E99DAAA60@DB6PR0501MB2518.eurprd05.prod.outlook.com>

Hi Noam,

On Tue, 2016-11-08 at 14:13 +0000, Noam Camus wrote:
> > 
> > From: Alexey Brodkin [mailto:Alexey.Brodkin@synopsys.com] 
> > Sent: Tuesday, November 8, 2016 4:08 PM
> 
> > 
> > Could you please provide a changelog (v1 -> v2) so reviewers may have a hint about changes you made if any.
> ... Just fix some typos in log
> This line somehow was removed from patch while sending (It is at patch head followed by line with ---)
> Basically in V1 I wrote that default value is good while I meant is NOT good (fixed in V2).

Thanks for explanation.
IMHO it worth adding that kind of changelog on each next iteration so
please keep it in mind next time :)

-Alexey

  reply	other threads:[~2016-11-08 14:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08 13:20 [PATCH v2] ARC: [plat-eznps] set default baud for early console Noam Camus
2016-11-08 13:20 ` Noam Camus
2016-11-08 14:08 ` Alexey Brodkin
2016-11-08 14:08   ` Alexey Brodkin
2016-11-08 14:13   ` Noam Camus
2016-11-08 14:13     ` Noam Camus
2016-11-08 14:15     ` Alexey Brodkin [this message]
2016-11-08 14:15       ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478614492.5131.57.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.