All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "staging: nvec: remove managed resource from PS2 driver" has been added to the 4.4-stable tree
@ 2016-11-15 19:09 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-11-15 19:09 UTC (permalink / raw)
  To: marvin24, gregkh; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    staging: nvec: remove managed resource from PS2 driver

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     staging-nvec-remove-managed-resource-from-ps2-driver.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From 68fae2f3df455f53d0dfe33483a49020b3b758f3 Mon Sep 17 00:00:00 2001
From: Marc Dietrich <marvin24@gmx.de>
Date: Tue, 1 Nov 2016 13:59:40 +0100
Subject: staging: nvec: remove managed resource from PS2 driver

From: Marc Dietrich <marvin24@gmx.de>

commit 68fae2f3df455f53d0dfe33483a49020b3b758f3 upstream.

This basicly reverts commit e534f3e9 (staging:nvec: Introduce the use of
the managed version of kzalloc). Serio struct should never by managed
because it is refcounted. Doing so will lead to a double free oops on module
remove.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
Fixes: e534f3e9429f ("staging:nvec: Introduce the use of the managed version of kzalloc")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/staging/nvec/nvec_ps2.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/nvec/nvec_ps2.c
+++ b/drivers/staging/nvec/nvec_ps2.c
@@ -107,7 +107,7 @@ static int nvec_mouse_probe(struct platf
 	struct nvec_chip *nvec = dev_get_drvdata(pdev->dev.parent);
 	struct serio *ser_dev;
 
-	ser_dev = devm_kzalloc(&pdev->dev, sizeof(struct serio), GFP_KERNEL);
+	ser_dev = kzalloc(sizeof(struct serio), GFP_KERNEL);
 	if (!ser_dev)
 		return -ENOMEM;
 


Patches currently in stable-queue which might be from marvin24@gmx.de are

queue-4.4/revert-staging-nvec-ps2-change-serio-type-to-passthrough.patch
queue-4.4/staging-nvec-remove-managed-resource-from-ps2-driver.patch
queue-4.4/drivers-staging-nvec-remove-bogus-reset-command-for-ps-2-interface.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-11-15 19:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-15 19:09 Patch "staging: nvec: remove managed resource from PS2 driver" has been added to the 4.4-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.