All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "sparc: serial: sunhv: fix a double lock bug" has been added to the 4.4-stable tree
@ 2016-11-19  8:53 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2016-11-19  8:53 UTC (permalink / raw)
  To: dan.carpenter, davem, gregkh; +Cc: stable, stable-commits


This is a note to let you know that I've just added the patch titled

    sparc: serial: sunhv: fix a double lock bug

to the 4.4-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     sparc-serial-sunhv-fix-a-double-lock-bug.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.


>From foo@baz Sat Nov 19 09:52:37 CET 2016
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 15 Jul 2016 14:17:33 +0300
Subject: sparc: serial: sunhv: fix a double lock bug

From: Dan Carpenter <dan.carpenter@oracle.com>


[ Upstream commit 344e3c7734d5090b148c19ac6539b8947fed6767 ]

We accidentally take the "port->lock" twice in a row.  This old code
was supposed to be deleted.

Fixes: e58e241c1788 ('sparc: serial: Clean up the locking for -rt')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/tty/serial/sunhv.c |    6 ------
 1 file changed, 6 deletions(-)

--- a/drivers/tty/serial/sunhv.c
+++ b/drivers/tty/serial/sunhv.c
@@ -490,12 +490,6 @@ static void sunhv_console_write_bychar(s
 		locked = spin_trylock_irqsave(&port->lock, flags);
 	else
 		spin_lock_irqsave(&port->lock, flags);
-	if (port->sysrq) {
-		locked = 0;
-	} else if (oops_in_progress) {
-		locked = spin_trylock(&port->lock);
-	} else
-		spin_lock(&port->lock);
 
 	for (i = 0; i < n; i++) {
 		if (*s == '\n')


Patches currently in stable-queue which might be from dan.carpenter@oracle.com are

queue-4.4/sparc-serial-sunhv-fix-a-double-lock-bug.patch

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-11-19  8:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-19  8:53 Patch "sparc: serial: sunhv: fix a double lock bug" has been added to the 4.4-stable tree gregkh

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.